Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)"#124807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…rings. (pythongh-124646)"This reverts commit98b2ed7.
LGTM. |
7bdfabe intopython:main 38 checks passed
Uh oh!
There was an error while loading.Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 30, 2024
…ortal interned strings (pythongh-124646)" (pythongh-124807)Revert "pythongh-116510: Fix crash due to shared immortal interned strings. (pythongh-124646)"This reverts commit98b2ed7.(cherry picked from commit7bdfabe)Co-authored-by: T. Wouters <thomas@python.org>
Sorry,@Yhg1s and@nascheme, I could not cleanly backport this to |
GH-124812 is a backport of this pull request to the3.13 branch. |
Yhg1s added a commit that referenced this pull requestOct 1, 2024
… interned strings (gh-124646)" (gh-124807) (#124812)gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" (gh-124807)Revert "gh-116510: Fix crash due to shared immortal interned strings. (gh-124646)"This reverts commit98b2ed7.(cherry picked from commit7bdfabe)Co-authored-by: T. Wouters <thomas@python.org>
Yhg1s added a commit to Yhg1s/cpython that referenced this pull requestOct 1, 2024
…red immortal interned strings (pythongh-124646)" (pythongh-124807)Revert "pythongh-116510: Fix crash due to shared immortal interned strings. (pythongh-124646)"This reverts commit98b2ed7.(cherry picked from commit7bdfabe)Co-authored-by: T. Wouters <thomas@python.org>
GH-124818 is a backport of this pull request to the3.12 branch. |
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull requestOct 1, 2024
…ared immortal interned strings (pythongh-124646)" (pythongh-124807)"This reverts commit7bdfabe.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Revert the fix forgh-116510, since it causes crashes in the tracerefs build (and it makes invalid assumptions; see#124796 (comment)).