Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124771: Add thePYTHON_GC_PRESET env var.#124772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nascheme wants to merge2 commits intopython:main
base:main
Choose a base branch
Loading
fromnascheme:gc_strategy

Conversation

nascheme
Copy link
Member

@naschemenascheme commentedSep 29, 2024•
edited
Loading

This is still a WIP. We need to discuss if this is actually a good idea and what the options should be if it is.

There should be agc.set_preset() function, which is not yet implemented. Also need unit tests for this functionality. The initconfig logic is fairly complex and I'm not sure I did everything correct.

📚 Documentation preview 📚:https://cpython-previews--124772.org.readthedocs.build/

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The name PYTHON_GC_PRESET was suggested.

@nascheme
Copy link
MemberAuthor

The name PYTHON_GC_PRESET was suggested.

Yeah, that's a better name. I've updated the PR. Still need thegc.set_preset() function and some unit tests before this would be ready to merge.

@naschemenascheme changed the titlegh-124771: Add thePYTHON_GC_STRAGEGY env var.gh-124771: Add thePYTHON_GC_PRESET env var.Oct 1, 2024
@vstinner
Copy link
Member

The PR is a draft. Does it mean that you're not sure if it's a good idea or not? Should it be reviewed or not yet?

@nascheme
Copy link
MemberAuthor

The code is not yet complete (needgc.set_preset() andgc.get_preset()). Also, I'm hoping for some more discussion on the approach, both from other Python implementations like pypy and from GC experts like Joannah.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@pablogsalpablogsalAwaiting requested review from pablogsal

@nanjekyejoannahnanjekyejoannahAwaiting requested review from nanjekyejoannah

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner

Assignees
No one assigned
Labels
DO-NOT-MERGEinterpreter-core(Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nascheme@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp