Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124872: Change PyContext_WatchCallback to take PyObject#124737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
1st1 merged 1 commit intopython:mainfromrhansen:gh-119333-context-watch
Oct 12, 2024

Conversation

@rhansen
Copy link
Contributor

@rhansenrhansen commentedSep 28, 2024•
edited
Loading

The PyContext struct is not intended to be public, and users of the API don't need anything more specific than PyObject. Also seegh-78943.

I don't think a NEWS blurb is needed because this amends a feature that is new to v3.14 so theexisting blurb should suffice.

cc@fried

📚 Documentation preview 📚:https://cpython-previews--124737.org.readthedocs.build/

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@rhansenrhansen changed the titlegh-119333: Change PyContext_WatchCallback to take PyObjectgh-124872: Change PyContext_WatchCallback to take PyObjectOct 1, 2024
@rhansenrhansenforce-pushed thegh-119333-context-watch branch fromac65639 to7681358CompareOctober 10, 2024 08:45
@1st1
Copy link
Member

@rhansen please rebase

The PyContext struct is not intended to be public, and users of theAPI don't need anything more specific than PyObject.  Also seepythongh-78943.
@rhansenrhansenforce-pushed thegh-119333-context-watch branch from7681358 to79df721CompareOctober 12, 2024 20:28
Copy link
Member

@1st11st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good refactoring and jives well with the idea that C API should expose(PyObject*) for objects and not their concrete structs.

@1st11st1 merged commit330c527 intopython:mainOct 12, 2024
39 checks passed
@rhansenrhansen deleted the gh-119333-context-watch branchOctober 12, 2024 21:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhansen@1st1
[8]ページ先頭
©2009-2025 Movatter.jp