Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Make __subclasses__ doctest stable#124577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedSep 26, 2024•
edited by github-actionsbot
Loading

Using a standard library class makes this test difficult to maintain
as other tests and other parts of the stdlib may create subclasses,
which may still be alive when this test runs depending on GC timing.

📚 Documentation preview 📚:https://cpython-previews--124577.org.readthedocs.build/

Using a standard library class makes this test difficult to maintainas other tests and other parts of the stdlib may create subclasses,which may still be alive when this test runs depending on GC timing.
@JelleZijlstraJelleZijlstra merged commit08a467b intopython:mainSep 26, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks@JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 26, 2024
Using a standard library class makes this test difficult to maintainas other tests and other parts of the stdlib may create subclasses,which may still be alive when this test runs depending on GC timing.(cherry picked from commit08a467b)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@miss-islington-app
Copy link

Sorry,@JelleZijlstra, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 08a467b537b3d9b499d060697e79b3950374ab0f 3.12

@bedevere-app
Copy link

GH-124579 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 26, 2024
@JelleZijlstraJelleZijlstra deleted the subclassessubclasses branchSeptember 26, 2024 06:32
@bedevere-app
Copy link

GH-124580 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 26, 2024
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull requestSep 26, 2024
…124577)Using a standard library class makes this test difficult to maintainas other tests and other parts of the stdlib may create subclasses,which may still be alive when this test runs depending on GC timing.(cherry picked from commit08a467b)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra added a commit that referenced this pull requestSep 26, 2024
…4580)Using a standard library class makes this test difficult to maintainas other tests and other parts of the stdlib may create subclasses,which may still be alive when this test runs depending on GC timing.(cherry picked from commit08a467b)
Yhg1s pushed a commit that referenced this pull requestSep 26, 2024
…4579)gh-101100: Make __subclasses__ doctest stable (GH-124577)Using a standard library class makes this test difficult to maintainas other tests and other parts of the stdlib may create subclasses,which may still be alive when this test runs depending on GC timing.(cherry picked from commit08a467b)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

@JelleZijlstraJelleZijlstra

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JelleZijlstra@kumaraditya303@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp