Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-124552 : Improve the accuracy of possible breakpoint check in bdb#124553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
iritkatriel commentedSep 26, 2024
This needs a test. |
Lib/bdb.py Outdated
| self.code_lineno[code]=set() | ||
| for_,_,linenoincode.co_lines(): | ||
| self.code_lineno[code].add(lineno) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| self.code_lineno[code]=set() | |
| for_,_,linenoincode.co_lines(): | |
| self.code_lineno[code].add(lineno) | |
| self.code_lineno[code]=set([lnofor_,_,lnoincode.co_lines()]) |
gaogaotiantian commentedSep 26, 2024
Do you think a test that directly tests |
gaogaotiantian commentedSep 27, 2024
I added a test for |
terryjreedy commentedSep 28, 2024
I am testing this with IDLE's bdb-based debugger now. |
terryjreedy commentedSep 28, 2024
No (new) problems found. Breakpoints at top level and in def still work. |
gaogaotiantian commentedSep 28, 2024
Thanks@terryjreedy for confirming this.#124533 might be another interesting one to test. |
Lib/bdb.py Outdated
| returnFalse | ||
| ifcodenotinself.code_lineno: | ||
| self.code_lineno[code]=set(linenofor_,_,linenoincode.co_lines()) | ||
| returnlinenoinself.code_lineno[frame.f_code] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| returnlinenoinself.code_lineno[frame.f_code] | |
| returnlinenoinself.code_lineno[code] |
Lib/bdb.py Outdated
| self.frame_returning=None | ||
| self.trace_opcodes=False | ||
| self.enterframe=None | ||
| self.code_lineno=weakref.WeakKeyDictionary() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| self.code_lineno=weakref.WeakKeyDictionary() | |
| self.code_linenos=weakref.WeakKeyDictionary() |
Misc/NEWS.d/next/Library/2024-09-25-22-06-52.gh-issue-124552.1nQKNM.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Lib/bdb.py Outdated
| raiseNotImplementedError("subclass of bdb must implement do_clear()") | ||
| defbreak_anywhere(self,frame): | ||
| """Return True if there is any breakpoint for frame's filename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this comment needs updating (it's not just filename now).
…nQKNM.rstCo-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
| ifself.stopframeandframe.f_code.co_flags&GENERATOR_AND_COROUTINE_FLAGS: | ||
| # It's possible to trigger a StopIteration exception in | ||
| # the caller so we must set the trace function in the caller | ||
| self._set_caller_tracefunc(frame) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
how is this related to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is a hidden bug which was exposed by the change ofbreak_anywhere. There's a test case ofbdb testing raisingStopIteration in a generator. It passed becausebreak_anywhere always returnTrue when the function was defined in the same file, which always sets the trace function on the caller because it is in the same file. That coincidence hide the bug where returning from a generator should stop in the caller. There's a similar call in line 177 - that's for the normal return case from#118979 - it's also my fix to a similar case.
Uh oh!
There was an error while loading.Please reload this page.
Now we check whether the line number is in the code object with
co_lines()so we can have an accurate answer.A bug needs to be fixed for generators. This is not caused by the new feature, but exposed. I put those together because the changes are very small. I can separate those if that's desired.