Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-124502: Add PyUnicode_Equal() function#124504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@picnixz@rruuaanng@ZeroIntensity: I addressed your comments. Please review the updated PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Final nitpick but you can ignore it (I don't know whether it's that useful).
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! LGTM.
Uh oh!
There was an error while loading.Please reload this page.
Maybe you are right, But you can consider my suggestion. |
I createdcapi-workgroup/decisions#43 issue in the C API Working Group. |
vstinner commentedSep 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I wrote a microbenchmark comparingequal strings of 10 characters: Results on Fedora 40 with CPU isolation:
Proposed public Private |
vstinner commentedSep 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Microbenchmark on comparison ofinequal strings of 10 characters, only the last character is different.
|
The C API Working Group approved the API. |
a7f0727 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Merged. Thanks for reviews@picnixz and@ZeroIntensity. |
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--124504.org.readthedocs.build/