Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119333: PyContext watchers notify get interp from tstate#124444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 3 commits intopython:mainfromfried:context_watchers_fixup
Sep 26, 2024

Conversation

@fried
Copy link
Contributor

@friedfried commentedSep 24, 2024•
edited by bedevere-appbot
Loading

This fixes a suggestion from#119335 that we should be getting the *interp from tstate instead.
Also attempting to clean up comments as suggested.

@fried
Copy link
ContributorAuthor

@kumaraditya303 Is this better?

@fried
Copy link
ContributorAuthor

Need a "skip news" label since the last pull had the news this is just a fix

Copy link
Member

@gvanrossumgvanrossum left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll merge now that Kumar approved.

Thanks for the updated PR!

fried reacted with heart emoji
@kumaraditya303kumaraditya303 merged commit46f5cbc intopython:mainSep 26, 2024
37 checks passed
@friedfried deleted the context_watchers_fixup branchSeptember 26, 2024 18:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fried@gvanrossum@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp