Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-123516: Improve JIT memory consumption by invalidating cold executors#124443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 79 commits intopython:mainfromsavannahostrowski:jit-inv-mem-100k
Sep 27, 2024

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commentedSep 24, 2024
edited
Loading

This PR succeeds#123402 and reworks the approach to use the eval breaker for the invalidation call instead of executor creation or gc (thanks@markshannon!). In experimenting, I tried a couple of different thresholds of 10k, 100k, and 1 million runs. The benchmarks for100k and1 million were most promising. Here are some relevant stats for quick reference:

100k
--2.4% memory
-Roughly the same performance-wise

1 million

After chatting with@brandtbucher, I've opted to open this PR with the 100k threshold. One thing to note is that we are potentially a little too liberal in invalidating executors with this threshold, but with the lack of movement in performance and a more substantial decrease in memory usage, it seemed justified. We can continue to iterate here and consider making this tunable in the future.

juanboterotech reacted with thumbs up emoji
savannahostrowskiand others added30 commitsAugust 27, 2024 18:55
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a nice change, thanks!

@brandtbucherbrandtbucherenabled auto-merge (squash)September 27, 2024 00:06
@brandtbucherbrandtbucher merged commit65f1237 intopython:mainSep 27, 2024
65 checks passed
@savannahostrowskisavannahostrowski deleted the jit-inv-mem-100k branchSeptember 27, 2024 16:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@brandtbucherbrandtbucherbrandtbucher approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savannahostrowski@picnixz@brandtbucher

[8]ページ先頭

©2009-2025 Movatter.jp