Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-124400: Use the normal command path for breakpoint commands#124401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Misc/NEWS.d/next/Library/2024-09-24-00-01-24.gh-issue-124400.0XCgfe.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…XCgfe.rstCo-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Misc/NEWS.d/next/Library/2024-09-24-00-01-24.gh-issue-124400.0XCgfe.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…XCgfe.rstCo-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Doc/library/pdb.rst Outdated
| If you have a command that resumes execution in the command list, the normal | ||
| frame information before you interact with pdb is not displayed. If none of | ||
| the other commands print anything, you see no sign that the breakpoint was | ||
| reached. | ||
| If you don't have a command that resumes execution in the command list, you | ||
| can also use the ``silent`` command anywhere in the command list to suppress | ||
| the frame information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we make this more concise? Is this new version correct?
| If you have a command that resumes execution in the command list, the normal | |
| frame information before you interact with pdb is not displayed. If none of | |
| the other commands print anything, you see no sign that the breakpoint was | |
| reached. | |
| If you don't have a command that resumes execution in the command list, you | |
| can also use the ``silent`` command anywhere in the command list to suppress | |
| the frame information. | |
| If the command list contains the ``silent`` command, or a command that | |
| resumes execution, then the breakpoint message containing information about | |
| the frame in which you last interacted with pdb is not displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I found "in which you last interacted with pdb" is a bit confusing to me. I do think it's better to put the two cases together, but maybe just say the information about the frame is not displayed? When I say "before you interact with pdb", I wanted to make it clear about what frame information. Maybe it's not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure 'before you interacted with on is clear' because the commands also interact with pdb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah I'm not saying my version is better. I'm thinking it might be enough for the users to just say information about the frame?
If the command list contains the
silentcommand, or a command that
resumes execution, then the breakpoint message containing information about
the frame is not displayed.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
b577460 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Cleaned up the code for
commandscommand so breakpoint commands will go through the normal parsing and executing path.Also a bug (#68328) is fixed for
untilin commands. A small behavior ofsilentis changed which matches the current behavior of.pdbrc(no interaction, no frame info).@iritkatriel sorry there are too many PRs, blame the sprint!
📚 Documentation preview 📚:https://cpython-previews--124401.org.readthedocs.build/