Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-121468: Show asyncio information in pdb#124367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gaogaotiantian merged 7 commits intopython:mainfromgaogaotiantian:pdb-asyncio-basic
Mar 14, 2025

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedSep 23, 2024
edited by bedevere-appbot
Loading

This is a draft because we still need to decide on the format.

I'm aiming for something short, the originalrepr of asyncio task is just too long. For now it's like

gaotian@gaotian-mba cpython % ./python.exe example.py             Task-1: <main pending>> /Users/gaotian/programs/cpython/example.py(11)main()-> breakpoint()

If pdb stops in an asyncio task, it will print an extra line showing the name of the task (Task-1), the name of the coroutine (main) and the status (pending).

As of now I think it will always bepending because we hit a breakpoint inside. However, we will add the feature to list all asyncio tasks in the future and allow switching between those, so we will have more status and it will be some important information.

I will work on the docs and the tests as long as the format is okay.

jloehel reacted with eyes emoji
@@ -79,6 +79,7 @@
import codeop
import pprint
import signal
import asyncio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Line 614 has deferred import ofasyncio.base_futures, so we could consider adding a lazy import ofasyncio at line 606 to improve import time?

#109653
#118761

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

asyncio will be used as long as pdb is used.pdb is not an module that is often imported explicitly or implicitly, I don't think import time ofpdb is specifically critical.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're right. I didn't realize that at the time

Lib/pdb.py Outdated
@@ -596,6 +602,38 @@ def _hold_exceptions(self, exceptions):
self._chained_exceptions = tuple()
self._chained_exception_index = 0

def _get_asyncio_loop_and_task(self):
try:
loop = asyncio.get_event_loop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can replace this with direct call to current_task and if it exists get loop from it, using get_event_loop can have unwanted consequences

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah I will change this.

@gaogaotiantiangaogaotiantian marked this pull request as ready for reviewMarch 11, 2025 22:02
@gaogaotiantian
Copy link
MemberAuthor

Okay I want to move this forward so I decided to do baby step. For this PR, I only added the$_asynctask variable. The extra print could break some tests so I removed it for now. We'll see if we ever want to implement that. We can put the information forasynctasks command in the future. This PR should be really benign as the first step to support asyncio.

@gaogaotiantiangaogaotiantian merged commit27fc62c intopython:mainMar 14, 2025
43 checks passed
@gaogaotiantiangaogaotiantian deleted the pdb-asyncio-basic branchMarch 14, 2025 18:46
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Android 3.x (tier-3) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/1586) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/1586

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotiOS ARM64 Simulator 3.x (tier-3) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/2883) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/2883

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/buildbot/Library/Developer/XCTestDevices/E71C4EE5-FC1E-4FD1-9774-EAA918A785F6/data/Containers/Bundle/Application/940EE364-2EBF-4FC4-9C96-18A2FD8CEA2A/iOSTestbed.app/python/lib/python3.14/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/Users/buildbot/Library/Developer/XCTestDevices/E71C4EE5-FC1E-4FD1-9774-EAA918A785F6/data/Containers/Bundle/Application/940EE364-2EBF-4FC4-9C96-18A2FD8CEA2A/iOSTestbed.app/python/lib/python3.14/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Android 3.x (tier-3) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1591/builds/1479) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1591/builds/1479

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL8 Refleaks 3.x (tier-3) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/75/builds/2315) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/75/builds/2315

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/1028) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/1028

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL9 Refleaks 3.x (tier-3) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1589/builds/1115) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1589/builds/1115

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 MacOS M1 Refleaks NoGIL 3.x (tier-2) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1368/builds/2817) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1368/builds/2817

Failed tests:

  • test_pdb
  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_release_task_refs - test.test_multiprocessing_spawn.test_processes.WithProcessesTestPool.test_release_task_refs

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctaskTraceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line3052, intest_release_task_refsself.assertEqual(CountedObject.n_instances,0)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:5 != 0

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL8 Refleaks 3.x (tier-1) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/259/builds/2320) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/259/builds/2320

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.refleak/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.refleak/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/957) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/957

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctask

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Fedora Stable Refleaks 3.x (tier-1) has failed when building commit27fc62c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/320/builds/2113) and take a look at the build logs.
  4. Check if the failure is related to this commit (27fc62c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/320/builds/2113

Failed tests:

  • test_pdb

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/doctest.py", line2327, inrunTestraiseself.failureException(self.format_failure(new.getvalue()))AssertionError:Failed doctest test for test.test_pdb.test_pdb_asynctask  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_pdb.py", line2063, intest_pdb_asynctask

@freakboy3742
Copy link
Contributor

The iOS and Android test appear to be passing on a re-run; trying to see if I can identify the cause.

@freakboy3742
Copy link
Contributor

@gaogaotiantian I can confirm this isn't an iOS/Android issue - it's an issue with test ordering.

I can reproduce the test failure on macOS by runningpython -m test test_asyncio.test_unix_events test_pdb. I'm guessing any test that touches asyncio in the same thread as test_pdb would trigger the bug. I haven't tested this on non-Apple platforms, but I suspect the behavior would exist.

The failure isn't a failure of the test itself - it's a failure caused by the test modifying the test environment:

0:09:33 load avg: 904.14 [302/485] test_pdbWarning -- asyncio.events._event_loop_policy was modified by test_pdbWarning --   Before: NoneWarning --   After:  <asyncio.unix_events._UnixDefaultEventLoopPolicy object at 0x1044be9f0> 0:09:42 load avg: 901.17 [302/485/1] test_pdb failed (env changed)

On a re-run, the test passes, because on entry, the test already has an event loop policy. What isn't clear to me is why thisisn't a failure when you run the test by itself.

I'm not completely sure what the right fix is here. Callingasyncio.events._set_event_loop_policy(None) in the__exit__ ofPdbTestInput seems to work, but I'm not sure if that would have other unintended consequences (plus, it's a deprecated method).

@gaogaotiantian
Copy link
MemberAuthor

@freakboy3742 Thank you for finding this. I checked the other code usingasyncio.run, and they all have a policy cleanup at the end of the test. So my question is - what are we going to do with those tests? Is there a replacement for the deprecated method? What are the rules for future asyncio tests? Should we just avoid usingasyncio.run in our tests (do it in a separate process)?

plashchynski pushed a commit to plashchynski/cpython that referenced this pull requestMar 17, 2025
@freakboy3742
Copy link
Contributor

g>@freakboy3742 Thank you for finding this. I checked the other code usingasyncio.run, and they all have a policy cleanup at the end of the test. So my question is - what are we going to do with those tests? Is there a replacement for the deprecated method? What are the rules for future asyncio tests?

I won't profess to being an asyncio expert - but my understanding is that the method is being deprecated because the underlying feature is no longer required, so there's no replacement API. My guess is that when the deprecation process is finalised, this "policy cleanup" bug will also disappear - because there's no state that will be inconsistent between the start and end of the test.

I'll push up a PR that implements this fix, and tag someone with more async experience to make sure I'm not missing anything.

Should we just avoid usingasyncio.run in our tests (do it in a separate process)?

FWIW - that approach won't work (or, at least, if you use that approach, the test won't run be able to run at all on iOS, Android or Emscripten) - mobile and web platforms don't support subprocesses.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Wulian233Wulian233Wulian233 left review comments

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@iritkatrieliritkatrielAwaiting requested review from iritkatriel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@gaogaotiantian@bedevere-bot@freakboy3742@kumaraditya303@Wulian233

[8]ページ先頭

©2009-2025 Movatter.jp