Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123990: Good bye WITH_FREELISTS macro#124358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 7 commits intopython:mainfromcorona10:gh-123990
Sep 24, 2024
Merged

Conversation

@corona10
Copy link
Member

@corona10corona10 commentedSep 23, 2024•
edited by bedevere-appbot
Loading

Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few minor comments below, but otherwise LGTM

@@ -0,0 +1 @@
Remove ``WITH_FREELISTS`` macro and ``--with-freelists`` build configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's the--without-freelists configuration that got removed, right?

(The--with-freelists configuration was the default)

corona10 reacted with thumbs up emoji
if (PyFloat_CheckExact(op)) {
_PyFloat_ExactDealloc(op);
}
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think you can move the{ up to the same line as theelse now

corona10 reacted with thumbs up emoji
@corona10corona10enabled auto-merge (squash)September 23, 2024 23:40
@corona10corona10 merged commitad7c778 intopython:mainSep 24, 2024
33 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@methanemethaneAwaiting requested review from methanemethane is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10@colesbury
[8]ページ先頭
©2009-2025 Movatter.jp