Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119180: Avoid going through AST and eval() when possible in annotationlib#124337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 11 commits intopython:mainfromJelleZijlstra:pep649-optanno
Sep 25, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedSep 23, 2024•
edited by bedevere-appbot
Loading

Often, ForwardRefs represent a single simple name. In that case, we can avoid going through the overhead of creating AST nodes and code objects and calling eval(): we can simply look up the name directly in the relevant namespaces.

This PR incorporates the changes from#124326 (which fixes a bug that I discovered while working on this change).

…onlib module scopeWe were sometimes passing None as the globals argument to eval(), which makes itinherit the globals from the calling scope. Instead, ensure that globals is alwaysnon-None. The test was passing accidentally because I passed "annotationlib" as amodule object; fix that. Also document the parameters to ForwardRef() and removetwo unused private ones.
…s and eval()Often, ForwardRefs represent a single simple name. In that case, wecan avoid going through the overhead of creating AST nodes and codeobjects and calling eval(): we can simply look up the name directlyin the relevant namespaces.
@JelleZijlstraJelleZijlstra marked this pull request as ready for reviewSeptember 24, 2024 17:22
Copy link
Member

@vstinnervstinner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I just have minor coding style suggestions that you can ignore if you prefer.

Co-authored-by: Victor Stinner <vstinner@python.org>
@JelleZijlstra
Copy link
MemberAuthor

Thanks@vstinner for the review!

@JelleZijlstraJelleZijlstraenabled auto-merge (squash)September 25, 2024 20:52
@JelleZijlstraJelleZijlstra merged commit17a544b intopython:mainSep 25, 2024
32 checks passed
emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull requestSep 26, 2024
* main: (69 commits)  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)pythongh-124412: Add helpers for converting annotations to source format (python#124551)pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)  For-else deserves its own section in the tutorial (python#123946)  Add 3.13 as a version option to the crash issue template (python#124560)pythongh-123242: Note that type.__annotations__ may not exist (python#124557)pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)pythongh-124370: Add "howto" for free-threaded Python (python#124371)pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameterspython#119400  (pythonGH-119401)pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)pythongh-124513: Check args in framelocalsproxy_new() (python#124515)pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JelleZijlstra@vstinner@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp