Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123873: sqlite3.threadsafety aligned with python module capabilities#124316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rghe wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromrghe:gh-123873

Conversation

rghe
Copy link
Contributor

@rgherghe commentedSep 22, 2024•
edited by bedevere-appbot
Loading

@ZeroIntensity
Copy link
Member

This is a user-facing bug, we need a news entry.

@rghe
Copy link
ContributorAuthor

News added, thank you.

@ZeroIntensity
Copy link
Member

I've added the sqlite topic label to get some people who are more familiar with the module on this -- the ASan failures have me a little worried.

…zdy2x.rstCo-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, I don't know what happened with ASan. LGTM.

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedSep 24, 2024•
edited
Loading

Thanks, but I'd prefer if we fixed the root cause. Landing this inmain won't help anybody anyway, and backporting to 3.13 is probably out of the question now that we're so close to the final release. (It would have to be 3.13.1 earliest.)

@rghe
Copy link
ContributorAuthor

Yes, I understand, but IMHO, even with#118172 fixed, the sqlite module can't share cursors between threads without extensive changes, so returning 3 is still a bug.
Fixing#118172 should allow connection sharing, however, so perhaps a better fix would be returning 2 ?
BTW, I'd like to help, if you think it could be useful.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@rghe@ZeroIntensity@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp