Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-116622: Complete Android documentation#124259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 15 commits intopython:mainfrommhsmith:android-docs
Sep 23, 2024

Conversation

mhsmith
Copy link
Member

@mhsmithmhsmith commentedSep 20, 2024•
edited
Loading

The Android x86_64 buildbot is not yet up and running, so the statement that "Android is now a PEP 11 supported platform" is not quite ready to be merged, but I'd like to get an early review.

Summary:

  • Add an Android page to the "Setup and Usage" section.
  • Generalize the "Notes on availability" section to cover both iOS and Android.
  • Add "availability" markers to the modules and functions not supported on Android.

📚 Documentation preview 📚:https://cpython-previews--124259.org.readthedocs.build/

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This all looks good to me from a technical perspective; I'd like someone with more of a documentation eye (@hugovk?) to weigh in on any of the markup and layout aspects.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am not expert in Android, WASM or iOS, but this LGTM.


* `Briefcase <https://briefcase.readthedocs.io>`__, from the BeeWare project
* `Buildozer <https://buildozer.readthedocs.io>`__, from the Kivy project
* `Chaquopy <https://chaquo.com/chaquopy>`__

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are affiliated with this, right? I do not think there is a problem here, taking into account open-sourcing Chaquopy and your contribution in CPython.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Correct - Malcolm is the founder of Chaquopy.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've expanded this list to include all the production-quality Python-on-Android tools that I'm aware of.

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Two quick comments:

@AA-TurnerAA-Turner requested review fromAA-Turner and removed request forpradyunsg,corona10 anderlend-aaslandSeptember 23, 2024 15:13
@Yhg1s
Copy link
Member

Russel mentioned the android buildbot is now all set up and working, so is this ready to go in? :)

@freakboy3742
Copy link
Contributor

@Yhg1s 2 Android buildbots are up and running:

The failures on the arm64 buildbot occur inconsistently; they would be been addressed by#123988,#124034, and#124035. Those 3 PRs alter the test suite and the Android test runner to make test conditions reproducible.

@AA-TurnerAA-Turnerenabled auto-merge (squash)September 23, 2024 22:55
@AA-TurnerAA-Turner added the docsDocumentation in the Doc dir labelSep 23, 2024
@AA-TurnerAA-Turner merged commite80dd30 intopython:mainSep 23, 2024
24 checks passed
@miss-islington-app
Copy link

Thanks@mhsmith for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 23, 2024
(cherry picked from commite80dd30)Co-authored-by: Malcolm Smith <smith@chaquo.com>Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>Co-authored-by: T. Wouters <thomas@python.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-124395 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 23, 2024
Yhg1s added a commit that referenced this pull requestSep 24, 2024
gh-116622: Complete Android documentation (GH-124259)(cherry picked from commite80dd30)Co-authored-by: Malcolm Smith <smith@chaquo.com>Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>Co-authored-by: T. Wouters <thomas@python.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@mhsmith@Yhg1s@freakboy3742@serhiy-storchaka@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp