Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124248: Fix crash in struct when processing 0p fields#124251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 5 commits intopython:mainfrombrianschubert:gh-124248-struct-0p
Sep 20, 2024

Conversation

@brianschubert
Copy link
Member

Fixesgh-124248.

Adds special handling for the case whencode->size is 0 before attempting to decrementcode->size or read the first byte underres.

After this change,0p should behave like0s.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinnervstinner added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsSep 20, 2024
@vstinnervstinner merged commit63f1960 intopython:mainSep 20, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks@brianschubert for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 20, 2024
…nGH-124251)(cherry picked from commit63f1960)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@bedevere-app
Copy link

GH-124277 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 20, 2024
…nGH-124251)(cherry picked from commit63f1960)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@bedevere-app
Copy link

GH-124278 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 20, 2024
@vstinner
Copy link
Member

Merged, thanks for the bug report and the fix!

brianschubert reacted with heart emoji

vstinner pushed a commit that referenced this pull requestSep 20, 2024
…24251) (#124278)gh-124248: Fix crash in struct when processing 0p fields (GH-124251)(cherry picked from commit63f1960)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull requestSep 22, 2024
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull requestSep 22, 2024
Yhg1s pushed a commit that referenced this pull requestSep 30, 2024
…24251) (#124277)gh-124248: Fix crash in struct when processing 0p fields (GH-124251)(cherry picked from commit63f1960)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tomasr8tomasr8tomasr8 left review comments

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SystemError/Assertion failure when processing struct with '0p' field

3 participants

@brianschubert@vstinner@tomasr8
[8]ページ先頭
©2009-2025 Movatter.jp