Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123085: _compile_importlib: Avoid copying sources before compilation#124131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 4 commits intopython:mainfromencukou:compile-importlib
Sep 18, 2024

Conversation

encukou
Copy link
Member

@encukouencukou commentedSep 16, 2024•
edited by bedevere-appbot
Loading

Make the test helper compile directly from the “installed” sources.
This should avoid doing some unnecessary work, as well as possible issues in copying too much/too little metadata to a different filesystem. Hopefully, it'll fix the buildbot failure.

@encukou
Copy link
MemberAuthor

This now doesn't copyresources ofimportlib.resources, which we currently don't have.
Assuming the overall approach is fine, would it be OK to mention resources in a comment, or should this also copy non-.py files? Either way, there's no good way to test what would happen if some resources were there.

jaraco reacted with thumbs up emoji

@encukou
Copy link
MemberAuthor

!buildbot fedora

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commitcade8d2 🤖

The command will test the builders whose names match following regular expression:fedora

The builders matched are:

  • s390x Fedora Clang PR
  • PPC64LE Fedora Stable Clang Installed PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x Fedora LTO + PGO PR
  • AMD64 Fedora Stable Clang PR
  • aarch64 Fedora Rawhide PR
  • PPC64 Fedora PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • aarch64 Fedora Rawhide Refleaks PR
  • s390x Fedora Rawhide Clang PR
  • AMD64 Fedora Stable LTO PR
  • PPC64LE Fedora Rawhide PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 Fedora Stable PR
  • s390x Fedora PR
  • aarch64 Fedora Stable Clang PR
  • s390x Fedora Clang Installed PR
  • AMD64 Fedora Rawhide Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Stable Clang PR
  • PPC64LE Fedora Stable LTO PR
  • aarch64 Fedora Rawhide NoGIL PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • AMD64 Fedora Rawhide NoGIL PR
  • AMD64 Fedora Stable PR
  • aarch64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Rawhide PR
  • PPC64LE Fedora Rawhide Clang PR
  • s390x Fedora Refleaks PR
  • aarch64 Fedora Rawhide Clang PR
  • s390x Fedora LTO PR
  • PPC64LE Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Rawhide LTO PR
  • s390x Fedora Rawhide LTO + PGO PR
  • PPC64LE Fedora Stable Refleaks PR
  • PPC64LE Fedora Stable PR
  • aarch64 Fedora Stable LTO PR
  • AMD64 Fedora Rawhide LTO PR
  • AMD64 Fedora Stable Clang Installed PR
  • AMD64 Fedora Rawhide Clang PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • aarch64 Fedora Rawhide LTO PR
  • PPC64LE Fedora Rawhide NoGIL PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • s390x Fedora Rawhide PR
  • s390x Fedora Rawhide LTO PR
  • aarch64 Fedora Stable Clang Installed PR
  • AMD64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Rawhide LTO + PGO PR
  • AMD64 Fedora Rawhide Clang Installed PR
  • AMD64 Fedora Stable Refleaks PR
  • s390x Fedora Rawhide Refleaks PR

@encukouencukou marked this pull request as ready for reviewSeptember 17, 2024 09:01
@jaraco
Copy link
Member

!buildbot fedora

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@jaraco for commit8cd8fe9 🤖

The command will test the builders whose names match following regular expression:fedora

The builders matched are:

  • s390x Fedora Clang PR
  • PPC64LE Fedora Stable Clang Installed PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x Fedora LTO + PGO PR
  • AMD64 Fedora Stable Clang PR
  • aarch64 Fedora Rawhide PR
  • PPC64 Fedora PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • aarch64 Fedora Rawhide Refleaks PR
  • s390x Fedora Rawhide Clang PR
  • AMD64 Fedora Stable LTO PR
  • PPC64LE Fedora Rawhide PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 Fedora Stable PR
  • s390x Fedora PR
  • aarch64 Fedora Stable Clang PR
  • s390x Fedora Clang Installed PR
  • AMD64 Fedora Rawhide Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Stable Clang PR
  • PPC64LE Fedora Stable LTO PR
  • aarch64 Fedora Rawhide NoGIL PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • AMD64 Fedora Rawhide NoGIL PR
  • AMD64 Fedora Stable PR
  • aarch64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Rawhide PR
  • PPC64LE Fedora Rawhide Clang PR
  • s390x Fedora Refleaks PR
  • aarch64 Fedora Rawhide Clang PR
  • s390x Fedora LTO PR
  • PPC64LE Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Rawhide LTO PR
  • s390x Fedora Rawhide LTO + PGO PR
  • PPC64LE Fedora Stable Refleaks PR
  • PPC64LE Fedora Stable PR
  • aarch64 Fedora Stable LTO PR
  • AMD64 Fedora Rawhide LTO PR
  • AMD64 Fedora Stable Clang Installed PR
  • AMD64 Fedora Rawhide Clang PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • aarch64 Fedora Rawhide LTO PR
  • PPC64LE Fedora Rawhide NoGIL PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • s390x Fedora Rawhide PR
  • s390x Fedora Rawhide LTO PR
  • aarch64 Fedora Stable Clang Installed PR
  • AMD64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Rawhide LTO + PGO PR
  • AMD64 Fedora Rawhide Clang Installed PR
  • AMD64 Fedora Stable Refleaks PR
  • s390x Fedora Rawhide Refleaks PR

@jaraco
Copy link
Member

I pushed a new commit to trim down the logic substantially. Let me know what you think.

@encukou
Copy link
MemberAuthor

Looks good, thank you!

@encukouencukou merged commit42c8b05 intopython:mainSep 18, 2024
87 of 88 checks passed
@encukouencukou deleted the compile-importlib branchSeptember 18, 2024 12:14
@zwarezware mentioned this pull requestSep 18, 2024
@jaraco
Copy link
Member

I cherry-picked the change topython/importlib_resources@cc5d9cbb6e.

encukou reacted with heart emoji

savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull requestSep 22, 2024
…pilation (pythonGH-124131)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@encukouencukou added the needs backport to 3.12only security fixes labelJan 7, 2025
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 7, 2025
…pilation (pythonGH-124131)(cherry picked from commit42c8b05)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app
Copy link

GH-128581 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 7, 2025
encukou added a commit that referenced this pull requestJan 7, 2025
…mpilation (GH-124131) (GH-128581)gh-123085: _compile_importlib: Avoid copying sources before compilation (GH-124131)(cherry picked from commit42c8b05)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@jaracojaracojaraco approved these changes

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@encukou@bedevere-bot@jaraco@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp