Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-124127: Make Py_REFCNT() opaque in limited C API 3.14#124128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I plan to merge this change at the end of the week, unless someone wants to review it or has concerns about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1, with a nitpick on the implementation:
| } | ||
| #if !defined(Py_LIMITED_API)||Py_LIMITED_API+0<0x030b0000 | ||
| # definePy_REFCNT(ob) Py_REFCNT(_PyObject_CAST(ob)) | ||
| #if !defined(Py_LIMITED_API)||Py_LIMITED_API+0<0x030b0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This#if is now redundant, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's still needed. (Correct me if I'm wrong.)
9d344fa intopython:mainUh oh!
There was an error while loading.Please reload this page.
Merged, thanks for reviews. |
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--124128.org.readthedocs.build/