Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information#124103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 6 commits intopython:mainfromWulian233:build-ver
Sep 23, 2024

Conversation

@Wulian233
Copy link
Contributor

@Wulian233Wulian233 commentedSep 15, 2024•
edited
Loading

Inhttps://docs.python.org/3.14/using/configure.html.
Visual Studio 2017 or later is required, actually currently VS2015 is the minimum version.

VS2015 wasEOL in 2020 October

https://learn.microsoft.com/lifecycle/products/visual-studio-2015

So I removedVS2015 and earlier version support

Before this change, the description inpython.props stated:
https://github.com/python/cpython/blob/main/PCbuild/python.props#L8-L10

Use the latest available version of Visual Studio to build. To overridethis and build with an earlier version, pass "/p:PlatformToolset=v100"(for example) when building.

However, v100 corresponds toVisual Studio 2010, and now Visual Studio 2017 or later is required. v100 isno longer available. Seehttps://docs.python.org/3.14/using/configure.html.

Currently, the latest Visual Studio 2022 uses v143. Therefore, I have changed it to the officially supported Visual Studio 2017 (v141). Seehttps://github.com/python/cpython/blob/main/PCbuild/readme.txt#L62.

To correctly build CPython, the minimum Python required version is now 3.10; otherwise, it will download via NuGet online. Seehttps://github.com/python/cpython/blob/main/PCbuild/find_python.bat#L45

However, descriptions in other files are outdated, mentioning versions like 3.6, 2.7, and 3.4. Due to the long time lapse, these descriptions have become inconsistent across files. I have now standardized them

@terryjreedy
Copy link
Member

News entry needed. (I would also want it to merge.)

@Wulian233
Copy link
ContributorAuthor

No problem (Before I thought only changing the readme and syncing information not required NEWS😥)

NOTE: remove find VS2015 earlier bacause not support
@Wulian233
Copy link
ContributorAuthor

Wulian233 commentedSep 16, 2024•
edited
Loading

News entry needed. (I would also want it to merge.)

I have finished NEWS, in addition, I made env.bat support VS2017 and above version detection

@Wulian233Wulian233 changed the titlegh-124102: Update Dependency Information for PCBuild to Correct Informationgh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency InformationSep 17, 2024
@Wulian233
Copy link
ContributorAuthor

Hello@zooba , thank you for your review. I have made the changes, could you please review again? Thank you!

(I think I made some additional changes at the time, do you think these should be changed? I am considering revert the changes made to these two files)

Tools/c-analyzer/distutils/cygwinccompiler.py
Tools/c-analyzer/distutils/_msvccompiler.py

@zooba
Copy link
Member

Yeah, revert theTools directory changes and we're good to go (we explicitly aren't maintaining distutils anymore, including the copy used for tests, at least until the tests start breaking).

@Wulian233
Copy link
ContributorAuthor

Yeah, revert theTools directory changes and we're good to go (we explicitly aren't maintaining distutils anymore, including the copy used for tests, at least until the tests start breaking).

Finished 🚀

zooba reacted with rocket emoji

@zoobazoobaenabled auto-merge (squash)September 23, 2024 22:56
@zoobazooba merged commit27a62e7 intopython:mainSep 23, 2024
36 checks passed
@Wulian233Wulian233 deleted the build-ver branchSeptember 24, 2024 10:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zoobazoobazooba left review comments

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wulian233@terryjreedy@zooba
[8]ページ先頭
©2009-2025 Movatter.jp