Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present#124018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jaraco
Copy link
Member

@jaracojaraco commentedSep 12, 2024•
edited
Loading

@jaracojaraco added the needs backport to 3.13bugs and security fixes labelSep 12, 2024
@jaracojaraco marked this pull request as draftSeptember 12, 2024 18:33
@jaracojaracoforce-pushed thegh-123987/sentinel-in-namespace-path branch fromaaab6d2 to241d9e9CompareSeptember 12, 2024 18:35
@jaracojaraco changed the titlegh-123987: Fix issues in importlib.resources.gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel presentSep 12, 2024
@jaracojaracoforce-pushed thegh-123987/sentinel-in-namespace-path branch from241d9e9 to1c6608aCompareSeptember 12, 2024 19:38
@jaracojaraco marked this pull request as ready for reviewSeptember 12, 2024 19:40
@jaracojaracoenabled auto-merge (squash)January 5, 2025 21:57
@FFY00
Copy link
Member

ping@jaraco

This has been open for a while.

@jaraco
Copy link
MemberAuthor

ping@jaraco

This has been open for a while.

I've been trying not to merge code without review. I marked this one for auto-merge after review, but no one's reviewed it. Is there a reason you chose to ping me rather than review it? (not complaining, just curious)

I'll get it updated and merged.

@jaracojaraco self-assigned thisJan 26, 2025
@jaracojaracodisabled auto-mergeJanuary 26, 2025 16:06
@jaracojaracoenabled auto-merge (squash)January 26, 2025 16:07
@jaracojaraco merged commitb543b32 intopython:mainJan 26, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 26, 2025
…nel present (pythonGH-124018)(cherry picked from commitb543b32)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app
Copy link

GH-129319 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 26, 2025
@jaraco
Copy link
MemberAuthor

Oh, interesting! This is the first time I've seen the auto-merge work without a second person to review (and manual merge wasn't possible). Great to see some streamlining of workflows.

@jaracojaraco deleted the gh-123987/sentinel-in-namespace-path branchJanuary 26, 2025 17:03
jaraco added a commit that referenced this pull requestJan 26, 2025
…inel present (GH-124018) (#129319)gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present (GH-124018)(cherry picked from commitb543b32)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees

@jaracojaraco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaraco@FFY00
[8]ページ先頭
©2009-2025 Movatter.jp