Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-97588: remove unused functions in _ctypes/cfield.c#124010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

encukou merged 1 commit intopython:mainfromiritkatriel:unused

Sep 16, 2024

Merged

gh-97588: remove unused functions in _ctypes/cfield.c#124010

encukou merged 1 commit intopython:mainfromiritkatriel:unused

Sep 16, 2024

Conversation

@iritkatriel

Copy link

Member

iritkatriel commentedSep 12, 2024•
edited by bedevere-appbot
Loading

./Modules/_ctypes/cfield.c:49:12: warning: unused function 'round_down' [-Wunused-function]Py_ssize_t round_down(Py_ssize_t numToRound, Py_ssize_t multiple)           ^./Modules/_ctypes/cfield.c:59:12: warning: unused function 'round_up' [-Wunused-function]Py_ssize_t round_up(Py_ssize_t numToRound, Py_ssize_t multiple)           ^./Modules/_ctypes/cfield.c:409:12: warning: unused function 'BUILD_SIZE' [-Wunused-function]Py_ssize_t BUILD_SIZE(Py_ssize_t bitsize, Py_ssize_t offset) {

Issue:ctypes: bit field data does not survive round trip #97588

@iritkatriel

pythongh-97588: remove unused functions in _ctypes/cfield.c

1e4525b

@iritkatriel

iritkatriel added the skip news label

@bedevere-app

bedevere-appbot added the awaiting core review label

@bedevere-app

bedevere-appbot mentioned this pull request

ctypes: bit field data does not survive round trip#97588

Closed

@iritkatriel

iritkatriel requested review fromencukou andvstinner

September 12, 2024 15:05

@picnixz

picnixz mentioned this pull request

New build warnings:warning: unused function 'round_down' [-Wunused-function]#124122

Closed

@encukou

encukou merged commit453da53 intopython:main

@bedevere-app

bedevere-appbot removed the awaiting core review label

@encukou

Copy link

Member

encukou commentedSep 16, 2024

Thanks for the catch!

vstinner

vstinner reviewed

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Post-merge review: LGTM :-)

savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request

@iritkatriel

@savannahostrowski

pythongh-97588: remove unused functions in _ctypes/cfield.c (pythonGH…

5e54211

…-124010)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

3 participants

@iritkatriel

@encukou

@vstinner

[8]ページ先頭

©2009-2025 Movatter.jp