Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-108219: Add credits to free-threading project#123802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 8 commits intopython:mainfromcorona10:gh-108219-authors
Sep 8, 2024

Conversation

corona10
Copy link
Member

@corona10corona10 commentedSep 7, 2024
edited by github-actionsbot
Loading

argon-kr reacted with thumbs up emoji
@bedevere-appbedevere-appbot added the docsDocumentation in the Doc dir labelSep 7, 2024
@corona10corona10 added needs backport to 3.13bugs and security fixes and removed docsDocumentation in the Doc dir labelsSep 7, 2024
@@ -354,6 +354,10 @@ disabled with the :envvar:`PYTHON_GIL` environment variable or the
pip 24.1 or newer is required to install packages with C extensions in the
free-threaded build.

This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Ken Jin, Matt Page, and Sam Gross.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should this include@iritkatriel and a few others from Microsoft too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, not me.

willingc reacted with thumbs up emoji
Copy link
MemberAuthor

@corona10corona10Sep 7, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please let me know if I miss someone at Microsoft team.
cc@Fidget-Spinner

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure about this, I think there are too many contributors to try listing them exhaustively. Maybe go with something like "Sam Gross and many others"?

Copy link
MemberAuthor

@corona10corona10Sep 8, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Disclaimer: As the person listed in the description, I am biased, so I have no opinions about it.

But listing people as possible can give motivation to work projects not only for this but also other projects. For the faster-cpython project,they listed as many people as possible, so it was a great honor for me, and it motivated me to participate in other projects.
(And It can also be a good reference for persuading a company to let people work part-time on the CPython project.)

"Sam Gross and many others"?

I think this is the minimum option that should be used if there is controversy regarding this.

itamaro and darjeeling reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

And I also think there should be more people on the list. Please let me know or have the person update the description with more details.
(I just picked people with free-threading labels)

darjeeling reacted with thumbs up emoji
Copy link
Member

@Fidget-SpinnerFidget-SpinnerSep 8, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can't speak for the MS team because I'm also not employed by them :) but IMO/IIUC the MS team is focused on single-threaded JIT performance mostly. So they werent much involved in the 3.13 free threaded effort, apart from discussions and design help we received from them, which I'm thankful for.

corona10 and willingc reacted with thumbs up emoji
Comment on lines 357 to 360
This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,
Matt Page, and Sam Gross.
Meta has supported in the form of many engineer-years to this project.
Copy link
Member

@AA-TurnerAA-TurnerSep 8, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wording suggestions (on mobile so I can't easily check line wrapping)

Suggested change
This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,
Matt Page, and Sam Gross.
Meta has supported in the form of many engineer-years to this project.
This work is thanks to many people and organisations, including the large community of contributors
to Python and third party projects to test and enable free-threading support.
This includes, but is not limited to:
Sam Gross, Ken Jin, Donghee Na, Itamar Oren, Matt Page, Brett Simmers, and Dino Viehland.
Many of these contributors are employed by Meta Inc,
which has provided significant manpower to support this project.

corona10 and willingc reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, it's more better, and@itamaro is going to add more detail by next week :)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
corona10and others added2 commitsSeptember 8, 2024 19:03
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Itamar Oren <itamarost@gmail.com>
Copy link
Contributor

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@corona10 Thanks for making the effort to be inclusive with the credits after my initial comment. Looks good to me now.

corona10 reacted with heart emoji
@AA-TurnerAA-Turner merged commitaa3f11f intopython:mainSep 8, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks@corona10 for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 8, 2024
pythonGH-123802)(cherry picked from commitaa3f11f)Co-authored-by: Donghee Na <donghee.na@python.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Itamar Oren <itamarost@gmail.com>
@bedevere-app
Copy link

GH-123847 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 8, 2024
@corona10corona10 deleted the gh-108219-authors branchSeptember 9, 2024 01:07
Yhg1s pushed a commit that referenced this pull requestSep 24, 2024
…ew (GH-123802) (#123847)gh-108219: Add credits to the free-threading entry in What's New (GH-123802)(cherry picked from commitaa3f11f)Co-authored-by: Donghee Na <donghee.na@python.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Itamar Oren <itamarost@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner left review comments

@itamaroitamaroitamaro approved these changes

@willingcwillingcwillingc approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

@colesburycolesburyAwaiting requested review from colesbury

@Yhg1sYhg1sAwaiting requested review from Yhg1s

@hugovkhugovkAwaiting requested review from hugovk

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@corona10@itamaro@iritkatriel@hugovk@willingc@AA-Turner@Fidget-Spinner

[8]ページ先頭

©2009-2025 Movatter.jp