Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

Fix override value in os.rst#123522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

rffontenelle wants to merge2 commits intopython:main

base:main

Choose a base branch

fromrffontenelle:patch-5

Open

Fix override value in os.rst#123522

rffontenelle wants to merge2 commits intopython:mainfromrffontenelle:patch-5

Conversation

rffontenelle

Copy link

Contributor

rffontenelle commentedAug 30, 2024•
edited by github-actionsbot
Loading

In thepython -X cpu_count=n command line,n value is not overridden by anything. It actually overrides the defaultos.cpu_count()'s return value. So the text should say "override value" instead of "overridden value".

Please backport to 3.13

📚 Documentation preview 📚:https://cpython-previews--123522.org.readthedocs.build/

@rffontenelle

Fix override value in os.rst

4ae56da

@bedevere-app

bedevere-appbot added docs

Documentation in the Doc dir

skip news awaiting review labels

@vstinner

vstinner added the needs backport to 3.13bugs and security fixes label

@vstinner

vstinner requested a review fromcorona10

September 5, 2024 22:48

@hugovk

hugovk added the skip issue label

nanjekyejoannah

nanjekyejoannah reviewed

View reviewed changes

Doc/library/os.rst

		@@ -5555,7 +5555,7 @@ Miscellaneous System Information

		.. versionchanged:: 3.13
		If :option:`-X cpu_count <-X>` is given or :envvar:`PYTHON_CPU_COUNT` is set,
		:func:`cpu_count` returns theoverridden value n.
		:func:`cpu_count` returns theoverride value n.

Copy link

Contributor

nanjekyejoannahSep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The language is weird either way, may be 'overriding value'

Copy link

ContributorAuthor

rffontenelleSep 25, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi there. Shouldn't it be like "return value" used in these docs? (English is not my native language, so I could be mixing different things)

@rffontenelle

One more ocurrence

92b10dd

@serhiy-storchaka

serhiy-storchaka added the needs backport to 3.14bugs and security fixes label

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

awaiting review docs

Documentation in the Doc dir

needs backport to 3.13

bugs and security fixes

needs backport to 3.14

bugs and security fixes

skip issue skip news

5 participants

@rffontenelle

@nanjekyejoannah

@vstinner

@hugovk

@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp