Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123446: Fix empty function names inTypeErrors in_csv module (follow-up to gh-123461)#123462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 1 commit intopython:mainfromsobolevn:issue-123446-csv2
Aug 29, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedAug 29, 2024•
edited by bedevere-appbot
Loading

After:

>>>importcsv>>>csv.reader()Traceback (mostrecentcalllast):File"<python-input-3>",line1,in<module>csv.reader()~~~~~~~~~~^^TypeError:readerexpectedatleast1argument,got0>>>csv.writer()Traceback (mostrecentcalllast):File"<python-input-4>",line1,in<module>csv.writer()~~~~~~~~~~^^TypeError:writerexpectedatleast1argument,got0>>>csv.register_dialect()Traceback (mostrecentcalllast):File"<python-input-5>",line1,in<module>csv.register_dialect()~~~~~~~~~~~~~~~~~~~~^^TypeError:register_dialectexpectedatleast1argument,got0

Follow up to#123461

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

BTW,@sobolevn is a core developer and can merge his PRs.

hauntsaninja reacted with thumbs up emoji
@hauntsaninja
Copy link
Contributor

Oh right, for a while sobolevn didn't want to be one :-) Sorry for the early merge!

@sobolevn
Copy link
MemberAuthor

@hauntsaninja no worries, no harm done :)
Thanks everyone! 👏

@sobolevnsobolevn merged commit58ce131 intopython:mainAug 29, 2024
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sobolevn, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 58ce131037ecb34d506a613f21993cde2056f628 3.13

@miss-islington-app
Copy link

Sorry,@sobolevn, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 58ce131037ecb34d506a613f21993cde2056f628 3.12

sobolevn added a commit to sobolevn/cpython that referenced this pull requestAug 29, 2024
…_csv` module (pythonGH-123462)(cherry picked from commit58ce131)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-123466 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelAug 29, 2024
@picnixzpicnixz changed the titlegh-123446: Fix empty function names inTypeErrors in_csv modulegh-123446: Fix empty function names inTypeErrors in_csv module (follow-up to gh-123461)Aug 29, 2024
@picnixz
Copy link
Member

I just changed the title otherwise I thought there were twice the same PR on the tracker :')

@serhiy-storchaka
Copy link
Member

I am not sure that it is worth to backport this change. This is just a minor enhancement in error messages.

hauntsaninja reacted with thumbs up emoji

@sobolevn
Copy link
MemberAuthor

I am not sure that it is worth to backport this change. This is just a minor enhancement in error messages.

Ok, I can close them 👍

@hauntsaninjahauntsaninja removed the needs backport to 3.13bugs and security fixes labelAug 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

@sobolevnsobolevn

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@hauntsaninja@picnixz@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp