Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123424: addZipInfo._for_archive to set suitable default properties#123429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaraco merged 8 commits intopython:mainfrompicnixz:feat/zipfile-for-name-123424
Dec 29, 2024

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedAug 28, 2024•
edited by jaraco
Loading

Copy link
Member

@jaracojaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good. I have some thoughts about alternative approaches. Interested to hear what you think.

@Wulian233
Copy link
Contributor

Is there anything else that needs to be changed/discussion in this PR? I had another PR#124435 (which has been completed) that conflicted with these changes.

After merge, I can continue handle my PR :)

#124435 (review)

@picnixz
Copy link
MemberAuthor

I don't have time for this one sorry. I didn't implement the suggestion with composition due to other issues that seemed more pressing (and I don't plan to come back here before I'm done with providing HACL* HMAC, at least).

@jaracojaraco self-assigned thisDec 29, 2024
@jaracojaracoforce-pushed thefeat/zipfile-for-name-123424 branch fromf578f66 to44e7b75CompareDecember 29, 2024 18:07
@jaracojaraco changed the titlegh-123424: addZipInfo.for_name to construct aZipInfo for a file in an archivegh-123424: addZipInfo._for_archive to set suitable default propertiesDec 29, 2024
@jaracojaracoenabled auto-merge (squash)December 29, 2024 18:23
@jaracojaraco merged commit7e819ce intopython:mainDec 29, 2024
42 checks passed
@picnixz
Copy link
MemberAuthor

Thank you very much for taking over this@jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

@picnixzpicnixz deleted the feat/zipfile-for-name-123424 branchDecember 31, 2024 17:27
@jaraco
Copy link
Member

Thank you very much for taking over this@jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

No need to apologize. Thanks for the original work and being proactive about your availability.

picnixz reacted with heart emoji

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
…roperties (python#123429)---------Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/zipp that referenced this pull requestMay 12, 2025
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties---------Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/zipp that referenced this pull requestMay 12, 2025
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties---------Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaracojaraco mentioned this pull requestMay 26, 2025
jaraco added a commit to jaraco/zipp that referenced this pull requestMay 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jaracojaracojaraco approved these changes

Assignees

@jaracojaraco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract ZipInfo for archive functionality
3 participants
@picnixz@Wulian233@jaraco
[8]ページ先頭
©2009-2025 Movatter.jp