Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123228: don't leak file descriptors in pyrepl test#123302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@cfbolz
Copy link
Contributor

@cfbolzcfbolz commentedAug 24, 2024•
edited by bedevere-appbot
Loading

if no f_in and f_out arguments are given, _ReadlineWrapper calls os.dup on fd 0 and 1. Instead, just pass None, because the fds aren't needed anyway in this test.

skirpichev reacted with thumbs up emoji
if no f_in and f_out arguments are given, _ReadlineWrapper calls os.dupon fd 0 and 1. Instead, just pass None, because the fds aren't neededanyway in this test
@hauntsaninjahauntsaninja added 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section and removed awaiting merge labelsAug 24, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@hauntsaninja for commit20eb346 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelAug 24, 2024
@hauntsaninjahauntsaninja added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelAug 24, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@hauntsaninja for commit20eb346 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelAug 24, 2024
@cfbolz
Copy link
ContributorAuthor

ok, the refleak builds worked, the failures look unrelated.@hauntsaninja, I don't know what the usual approach is in such a situation? the commit definitely improves the buildbot situation.

@pablogsalpablogsal merged commitaa90592 intopython:mainAug 25, 2024
@pablogsal
Copy link
Member

ok, the refleak builds worked, the failures look unrelated.@hauntsaninja, I don't know what the usual approach is in such a situation? the commit definitely improves the buildbot situation.

Let's land it and back port it

@pablogsalpablogsal added the needs backport to 3.13bugs and security fixes labelAug 25, 2024
@miss-islington-app
Copy link

Thanks@cfbolz for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 25, 2024
…-123302)(cherry picked from commitaa90592)Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-app
Copy link

GH-123313 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelAug 25, 2024
@cfbolz
Copy link
ContributorAuthor

@pablogsal thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cfbolz@bedevere-bot@pablogsal@hauntsaninja
[8]ページ先頭
©2009-2025 Movatter.jp