Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123240: Raise input audit events in the new REPL#123274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfromsobolevn:issue-123240
Sep 5, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedAug 23, 2024•
edited by bedevere-appbot
Loading

There are no tests forinput() function in general, so I didn't include any unittests.

Manual testing:

>>>defaudithook(name,*args):...if"input"inname:print(name,args)...>>>importsys>>>sys.addaudithook(audithook)>>>input("abc ")builtins.input (('abc ',),)abcxyzbuiltins.input/result (('xyz',),)'xyz'

@skirpichev
Copy link
Contributor

There are no tests for input() function in general

$ git grep test_input Lib/test/test_builtin.pyLib/test/test_builtin.py:    def test_input(self):Lib/test/test_builtin.py:    def test_input_tty(self):Lib/test/test_builtin.py:    def test_input_tty_non_ascii(self):Lib/test/test_builtin.py:    def test_input_tty_non_ascii_unicode_errors(self):Lib/test/test_builtin.py:    def test_input_tty_null_in_prompt(self):Lib/test/test_builtin.py:    def test_input_tty_nonencodable_prompt(self):Lib/test/test_builtin.py:    def test_input_tty_nondecodable_input(self):Lib/test/test_builtin.py:    def test_input_no_stdout_fileno(self):Lib/test/test_builtin.py:    def test_inputtypes(self):

@sobolevn
Copy link
MemberAuthor

@skirpichev I mean_ReadlineWrapper.input :)

@ambvambv added the needs backport to 3.13bugs and security fixes labelSep 5, 2024
@ambvambv merged commitaa1339a intopython:mainSep 5, 2024
@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 5, 2024
…23274)(cherry picked from commitaa1339a)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-123737 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 5, 2024
ambv pushed a commit that referenced this pull requestSep 5, 2024
#123737)(cherry picked from commitaa1339a)Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@skirpichev@ambv
[8]ページ先頭
©2009-2025 Movatter.jp