Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123165: makedis functions render positions on demand#123168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 30 commits intopython:mainfrompicnixz:dis-show-positions-123165
Aug 21, 2024

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedAug 20, 2024•
edited
Loading

@picnixzpicnixzforce-pushed thedis-show-positions-123165 branch frombe826a5 toa934b4eCompareAugust 20, 2024 11:36
@picnixzpicnixzforce-pushed thedis-show-positions-123165 branch froma934b4e toa8eab11CompareAugust 20, 2024 11:36
@picnixzpicnixz marked this pull request as ready for reviewAugust 20, 2024 12:38
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. A few comments.

@picnixzpicnixz changed the titlegh-123165: add theshow_positions formal parameter todis functionsgh-123165: makedis functions render positions on demandAug 21, 2024
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool. A few more comments, nothing major.

@picnixzpicnixzforce-pushed thedis-show-positions-123165 branch from112fe26 toca3cf87CompareAugust 21, 2024 10:02
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Getting there. Some doc tweaks and a question.

@picnixz
Copy link
MemberAuthor

I marked your comments as resolved but I hoped I didn't miss any. By the way, thank you very much for your help@iritkatriel!

@iritkatriel
Copy link
Member

LGTM.@markshannon is this what you had in mind?

@markshannon
Copy link
Member

Yes

picnixz reacted with hooray emoji

@iritkatrieliritkatriel merged commitb1d3bd2 intopython:mainAug 21, 2024
@iritkatriel
Copy link
Member

Thank you@picnixz !

@picnixzpicnixz deleted the dis-show-positions-123165 branchAugust 21, 2024 13:50
@picnixz
Copy link
MemberAuthor

Thank you for your review as well, Irit!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@iritkatriel@markshannon
[8]ページ先頭
©2009-2025 Movatter.jp