NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

GH-99108: Fix Setup in addition to Setup.stdlib.in#123146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 1 commit intopython:mainfrommsprotz:hacl_blake2_setup

Aug 23, 2024

Merged

GH-99108: Fix Setup in addition to Setup.stdlib.in#123146

erlend-aasland merged 1 commit intopython:mainfrommsprotz:hacl_blake2_setup

Aug 23, 2024

Conversation

Copy link

Contributor

msprotz commentedAug 19, 2024•
edited by bedevere-appbot
Loading

See#119316

I don't think this warrants a NEWS entry

Issue:Replace built-in hashlib with verified implementations from HACL* #99108

Fix Setup in addition to Setup.stdlib.in

c2cc6f0

msprotz requested a review fromerlend-aasland as acode owner

August 19, 2024 14:59

bedevere-appbot mentioned this pull request

Aug 19, 2024

Replace built-in hashlib with verified implementations from HACL*#99108

Closed

bedevere-appbot added the awaiting review label

Aug 19, 2024

msprotz mentioned this pull request

Aug 19, 2024

gh-99108: Add HACL* Blake2 implementation to hashlib#119316

Merged

Copy link

ContributorAuthor

msprotz commentedAug 19, 2024

Just to be clear, my local build does not seem to pick up Setup and instead uses Setup.stdlin.in, so@asottile could you please confirm that this is good? Thank you.

Copy link

Contributor

asottile commentedAug 21, 2024

this looks correct to me -- or at least it matches the other ones. I could run a test build but that's going to take more time than I have free today :(

erlend-aasland approved these changes

Aug 23, 2024

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels

Aug 23, 2024

Copy link

Contributor

erlend-aasland commentedAug 23, 2024

this looks correct to me -- or at least it matches the other ones. I could run a test build but that's going to take more time than I have free today :(

There is no way to getModules/Setup "correct"; it never will be and it never has been. It should be removed, and the (few, hopefully) projects depending on it should find other ways to get what they need.