NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

[3.13] gh-123022: Fix crash with`Py_Initialize` in background thread (GH-123052)#123114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-d061ffe-3.13

Aug 17, 2024

Merged

[3.13] gh-123022: Fix crash with`Py_Initialize` in background thread (GH-123052)#123114

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-d061ffe-3.13

Aug 17, 2024

Conversation

Copy link

Contributor

miss-islington commentedAug 17, 2024•
edited by bedevere-appbot
Loading

Check that the current default heap is initialized in
_mi_os_get_aligned_hint andmi_os_claim_huge_pages.

The mimalloc function_mi_os_get_aligned_hint assumes that there is an
initialized default heap. This is true for our main thread, but not for
background threads. The problematic code path is usually called during
initialization (i.e.,Py_Initialize), but it may also be called if the
program allocates large amounts of memory in total.

The crash only affected the free-threaded build.
(cherry picked from commitd061ffe)

Co-authored-by: Sam Grosscolesbury@gmail.com

Issue:Crash inPy_Initialize in non-main thread in free-threading build #123022

pythongh-123022: Fix crash withPy_Initializein background thread (p…

ca630c3

…ythonGH-123052)Check that the current default heap is initialized in`_mi_os_get_aligned_hint` and `mi_os_claim_huge_pages`.The mimalloc function `_mi_os_get_aligned_hint` assumes that there is aninitialized default heap. This is true for our main thread, but not forbackground threads. The problematic code path is usually called duringinitialization (i.e., `Py_Initialize`), but it may also be called if theprogram allocates large amounts of memory in total.The crash only affected the free-threaded build.(cherry picked from commitd061ffe)Co-authored-by: Sam Gross <colesbury@gmail.com>