Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.13] gh-116608: Revert "[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) (#123051)"#123072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jaraco wants to merge1 commit intopython:3.13fromjaraco:revert-123051

Conversation

jaraco
Copy link
Member

@jaracojaraco commentedAug 16, 2024
edited by bedevere-appbot
Loading

This reverts commit5ac14ee.

This commit should be re-applied after 3.13.0 final.

…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"This reverts commit5ac14ee.This commit should be re-applied after 3.13.0 final.
@jaraco
Copy link
MemberAuthor

I guess technically this change should also be reviewed.

@jaracojaraco requested review fromencukou and removed request forwarsaw andFFY00August 16, 2024 16:12
@FFY00
Copy link
Member

@jaraco feel free to request a review from me in such cases. I do tend to keep up with the ongoing work in theimportlib_metadata andimportlib_resources backports, so it might be easier for me to have a look compared to others.

jaraco reacted with heart emoji

@jaraco
Copy link
MemberAuthor

An alternative to approving and merging this change could be to retroactively review and accept the changes for 3.13. I know we wouldn't normally apply such style-sync changes in an RC, but I also note that the AST doesn't change for the non-test code and changes only very modestly in tests. If@encukou would be okay with not applying this PR, that would be my preference.

@encukou
Copy link
Member

I agree that, since the mistake is made, it's better to keep the style changes in than to revert them and re-introduce later.
@Yhg1s, do you agree?

@Yhg1s
Copy link
Member

Yes, the changes seem benign enough that there's no point in reverting and reapplying.

@Yhg1sYhg1s closed thisSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouAwaiting requested review from encukou

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jaraco@FFY00@encukou@Yhg1s

[8]ページ先頭

©2009-2025 Movatter.jp