Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.13] gh-116608: Revert "[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) (#123051)"#123072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"This reverts commit5ac14ee.This commit should be re-applied after 3.13.0 final.
I guess technically this change should also be reviewed. |
@jaraco feel free to request a review from me in such cases. I do tend to keep up with the ongoing work in the |
An alternative to approving and merging this change could be to retroactively review and accept the changes for 3.13. I know we wouldn't normally apply such style-sync changes in an RC, but I also note that the AST doesn't change for the non-test code and changes only very modestly in tests. If@encukou would be okay with not applying this PR, that would be my preference. |
I agree that, since the mistake is made, it's better to keep the style changes in than to revert them and re-introduce later. |
Yes, the changes seem benign enough that there's no point in reverting and reapplying. |
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit5ac14ee.
This commit should be re-applied after 3.13.0 final.