Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-122937: Add docs about annotations evaluation order#123060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| 1. Value ``'miss-islington'`` will be assigned | ||
| to name ``username`` in ``User`` class scope | ||
| 2. Name ``str`` is evaluated in the annotated assignment statement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is incorrect in Python 3.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, yes, right! I guess we need two sections: one for 3.14+ and one for older versions.
How would you best describe the current approach? With a PEP link maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can only say that the proposed text looks fine, subject to it being true. Given Jelle's comment, we need separate main and branch patches, separately reviewed (or apply this and followup with a main-only patch). I believe the main patch should have a Changed note.
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--123060.org.readthedocs.build/