Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028)#123051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaraco merged 1 commit intopython:3.13frommiss-islington:backport-e913d2c-3.13
Aug 15, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedAug 15, 2024•
edited by bedevere-appbot
Loading

…_metadata. (pythonGH-123028)(cherry picked from commite913d2c)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaracojaraco changed the title[3.13] gh-116608: Apply style and compatibility changes from importlib_metadata. (GH-123028)[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028)Aug 15, 2024
@jaracojaracoenabled auto-merge (squash)August 15, 2024 19:34
@jaracojaraco merged commit5ac14ee intopython:3.13Aug 15, 2024
36 checks passed
@encukou
Copy link
Member

I don't think this is important enough for a release candidate fix.
Are you aware that in the RC phase,all changes need to be reviewed?

@jaraco
Copy link
Member

Oops. I wasn't aware that we were in RC phase. I guess I'd lost track of time.

I was considering this change blocking for#123037, not because the changes interact, but because when syncing the changes from importlib_resources@cpython to cpython@main, the files get copied wholesale (there's no VCS tracking), and these changes needed to be applied to get those codebases aligned.

I'll revert this change and then re-submit the backport to be blocked on cutting of 3.13.0.

jaraco added a commit to jaraco/cpython that referenced this pull requestAug 16, 2024
… from importlib_resources. (pythonGH-123028) (python#123051)"This reverts commit5ac14ee.This commit should be re-applied after 3.13.0 final.
jaraco added a commit to jaraco/cpython that referenced this pull requestAug 16, 2024
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"This reverts commit5ac14ee.This commit should be re-applied after 3.13.0 final.
@bedevere-app
Copy link

GH-123072 is a backport of this pull request to the3.13 branch.

@jaraco
Copy link
Member

#123072 is the revert.

jaraco added a commit to jaraco/cpython that referenced this pull requestAug 16, 2024
…pythongh-116608: Apply style and compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)""This reverts commit0a058bc.
@jaraco
Copy link
Member

And#123074 is the revert revert (re-apply) for after 3.13.0.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jaracojaracoAwaiting requested review from jaracojaraco is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@miss-islington@encukou@jaraco
[8]ページ先頭
©2009-2025 Movatter.jp