Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99108: Inform HACL when explicit_bzero is unavailable#123027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 1 commit intopython:mainfrommhsmith:hacl-explicit-bzero
Aug 15, 2024

Conversation

mhsmith
Copy link
Member

@mhsmithmhsmith commentedAug 14, 2024•
edited by bedevere-appbot
Loading

For context, see#99108 (comment).

This PR fixes the build on Android and RHEL7 by defining LINUX_NO_EXPLICIT_BZERO whenexplicit_bzero is unavailable. It turns out there was already an autoconf check for this function, so I reused it.

Instead of creating a new Makefile variable, I appended the definition to LIBHACL_CFLAGS. This may be useful if HACL uses it in other files in the future.

@mhsmith
Copy link
MemberAuthor

!buildbot RHEL7

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@mhsmith for commitc903381 🤖

The command will test the builders whose names match following regular expression:RHEL7

The builders matched are:

  • PPC64LE RHEL7 LTO + PGO PR
  • PPC64LE RHEL7 PR
  • PPC64LE RHEL7 LTO PR
  • AMD64 RHEL7 LTO + PGO PR
  • PPC64LE RHEL7 Refleaks PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 RHEL7 PR
  • AMD64 RHEL7 LTO PR

Copy link
Contributor

@msprotzmsprotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok that makes a lot of sense. Thank you!

@encukouencukou merged commit3950392 intopython:mainAug 15, 2024
49 of 51 checks passed
@encukou
Copy link
Member

Thank you!

blhsing pushed a commit to blhsing/cpython that referenced this pull requestAug 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@msprotzmsprotzmsprotz approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@mhsmith@bedevere-bot@encukou@msprotz@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp