Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring#122934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 4 commits intopython:mainfromfaster-cpython:fix-122821
Aug 13, 2024

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedAug 12, 2024•
edited by bedevere-appbot
Loading

@markshannon
Copy link
MemberAuthor

Performance on tier 1 maybe shows a slight (<1%) slowdown (it might be noise).
But that's a worst case, as tier2 should be unaffected (the extra instruction will be removed).

I'm not concerned by any possible tier 1 slowdown, as we are focusing our efforts on tier 2.

@pythonpython deleted a comment frombedevere-botAug 12, 2024
@iritkatriel
Copy link
Member

iritkatriel commentedAug 12, 2024•
edited
Loading

It would be good to add a test in test_monitoring about the branch location issue.

markshannon reacted with thumbs up emoji

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A minor nitpick.

…e-122821.WnAzTK.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@markshannonmarkshannon merged commitfe23f8e intopython:mainAug 13, 2024
@picnixz
Copy link
Member

@markshannon Wouldn't this need to be backported to 3.13 as well? (or maybe you are creating the backport manually?)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@iritkatriel@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp