Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-122905: Sanitize names in zipfile.Path.#122906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jaraco
Copy link
Member

@jaracojaraco commentedAug 11, 2024•
edited by bedevere-appbot
Loading

@jaraco
Copy link
MemberAuthor

This behavior has been published in jaraco/zipp since 2024-05-31, so I'm confident it's stable.

@jaracojaraco merged commit9cd0326 intopython:mainAug 11, 2024
@miss-islington-app
Copy link

Thanks@jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13.
🐍🍒⛏🤖

@jaracojaraco deleted the bugfix/122905-malformed-zipfile-path-inputs branchAugust 11, 2024 23:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 11, 2024
Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app
Copy link

GH-122922 is a backport of this pull request to the3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 11, 2024
Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelAug 11, 2024
@bedevere-app
Copy link

GH-122923 is a backport of this pull request to the3.12 branch.

@miss-islington-app
Copy link

Sorry,@jaraco, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.11

@miss-islington-app
Copy link

Sorry,@jaraco, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.10

@miss-islington-app
Copy link

Sorry,@jaraco, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.9

@miss-islington-app
Copy link

Sorry,@jaraco, I could not cleanly backport this to3.8 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.8

jaraco added a commit to jaraco/cpython that referenced this pull requestAug 12, 2024
jaraco added a commit to jaraco/cpython that referenced this pull requestAug 12, 2024
)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app
Copy link

GH-122925 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelAug 12, 2024
@jaraco
Copy link
MemberAuthor

I've proposed the backport to 3.11. I'm hoping to cherrypick that to 3.10 and earlier, assuming it's accepted, rather that cherry-picking the change in main and re-reconciling the conflicts.

pablogsal pushed a commit that referenced this pull requestAug 19, 2024
*gh-122905: Sanitize names in zipfile.Path. (#122906)Ported from zipp 3.19.1; refjaraco/zipp#119.(cherry picked from commit9cd0326)* [3.11]gh-122905: Sanitize names in zipfile.Path. (GH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/cpython that referenced this pull requestAug 19, 2024
…nGH-122906) (pythonGH-122925)*pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)* [3.11]pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)(cherry picked from commit795f259)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/cpython that referenced this pull requestAug 19, 2024
…GH-122906) (pythonGH-122925)*pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)* [3.11]pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)(cherry picked from commit795f259)Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app
Copy link

GH-123161 is a backport of this pull request to the3.9 branch.

@bedevere-app
Copy link

GH-123162 is a backport of this pull request to the3.8 branch.

@bedevere-app
Copy link

GH-123160 is a backport of this pull request to the3.10 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelAug 19, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull requestAug 22, 2024
@jaraco
Copy link
MemberAuthor

That's weird - all three backports (3.8, 3.9, 3.10) are failing on the macos runners, two of them with segmentation faults. I'm 99.9% certain these changes aren't directly implicated. I've restarted the runners to see if maybe that clears things up, but there seems to be some stability issues on those branches.

pablogsal pushed a commit that referenced this pull requestAug 22, 2024
[3.10] [3.11]gh-122905: Sanitize names in zipfile.Path. (GH-122906) (GH-122925)*gh-122905: Sanitize names in zipfile.Path. (GH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)* [3.11]gh-122905: Sanitize names in zipfile.Path. (GH-122906)Ported from zipp 3.19.1; refjaraco/zippGH-119.(cherry picked from commit9cd0326)(cherry picked from commit795f259)
@obfuskobfusk mentioned this pull requestAug 23, 2024
@obfusk
Copy link
Contributor

This introduced a regression:#123270.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@Guddu786iGuddu786iGuddu786i approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaracojaraco

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Malformed payload can lead to infinite loops in zipfile.Path

3 participants

@jaraco@obfusk@Guddu786i
[8]ページ先頭
©2009-2025 Movatter.jp