Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Support the "pager" binary in _pyrepl#122878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policyThis is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. IMO it's reasonable to trypager beforeless. On Fedora, there is nopager command, it will silently be ignored as expected which is fine.
skirpichev commentedSep 19, 2024
It's user-visible change, I think it worth a changelog entry. |
vstinner commentedSep 19, 2024
@stefanor: Seehttps://devguide.python.org/ for how to add a Changelog (NEWS) entry. |
stefanor commentedSep 19, 2024
Added a NEWS entry. |
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…e-122878.4iFpsB.rst
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…e-122878.4iFpsB.rstCo-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policy.This is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555(cherry picked from commit426569e)Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
GH-124242 is a backport of this pull request to the3.13 branch. |
vstinner commentedSep 19, 2024
Merged, thanks@stefanor. |
Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policy.This is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555
Support the "pager" binary in _pyrepl (GH-122878)Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policy.This is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555(cherry picked from commit426569e)Co-authored-by: Stefano Rivera <stefano@rivera.za.net>Co-authored-by: T. Wouters <thomas@python.org>
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy
This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555