Aug 11, 2024 · Aug 10, 2024 · Aug 10, 2024 · Aug 10, 2024 · Aug 10, 2024 · Aug 10, 2024
diff --git a/Doc/library/unittest.mock.rst b/Doc/library/unittest.mock.rst
  call is an awaitable.

    >>> mock = AsyncMock()
    >>>asyncio.iscoroutinefunction(mock)
    >>>inspect.iscoroutinefunction(mock)
    True
    >>> inspect.isawaitable(mock())  # doctest: +SKIP
    True
diff --git a/Doc/whatsnew/3.14.rst b/Doc/whatsnew/3.14.rst
  :c:macro:`!isfinite` available from :file:`math.h`
  since C99.  (Contributed by Sergey B Kirpichev in :gh:`119613`.)

 * :func:`!asyncio.iscoroutinefunction` is deprecated
  and will be removed in Python 3.16,
  use :func:`inspect.iscoroutinefunction` instead.
  (Contributed by Jiahao Li and Kumar Aditya in :gh:`122875`.)

 .. Add deprecations above alphabetically, not here at the end.

 .. include:: ../deprecations/c-api-pending-removal-in-3.15.rst
diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py

    def _check_callback(self, callback, method):
        if (coroutines.iscoroutine(callback) or
                coroutines.iscoroutinefunction(callback)):
                coroutines._iscoroutinefunction(callback)):
            raise TypeError(
                f"coroutines cannot be used with {method}()")
        if not callable(callback):
diff --git a/Lib/asyncio/coroutines.py b/Lib/asyncio/coroutines.py


 defiscoroutinefunction(func):
 importwarnings
 """Return True if func is a decorated coroutine function."""
 warnings._deprecated("asyncio.iscoroutinefunction",
 f"{warnings._DEPRECATED_MSG}; "
 "use inspect.iscoroutinefunction() instead",
 remove=(3,16))
 return_iscoroutinefunction(func)


 def_iscoroutinefunction(func):
 return (inspect.iscoroutinefunction(func)or
 getattr(func,'_is_coroutine',None)is_is_coroutine)

diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py
        Raise RuntimeError if there is a problem setting up the handler.
        """
        if (coroutines.iscoroutine(callback) or
                coroutines.iscoroutinefunction(callback)):
                coroutines._iscoroutinefunction(callback)):
            raise TypeError("coroutines cannot be used "
                            "with add_signal_handler()")
        self._check_signal(sig)
diff --git a/Lib/test/test_asyncio/test_pep492.py b/Lib/test/test_asyncio/test_pep492.py

        self.assertFalse(asyncio.iscoroutine(foo()))


    def test_iscoroutinefunction(self):
        async def foo(): pass
        self.assertTrue(asyncio.iscoroutinefunction(foo))
        with self.assertWarns(DeprecationWarning):
            self.assertTrue(asyncio.iscoroutinefunction(foo))

    def test_async_def_coroutines(self):
        async def bar():
diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py
 from test.test_asyncio import utils as test_utils
 from test import support
 from test.support.script_helper import assert_python_ok
 from test.support.warnings_helper import ignore_warnings


 def tearDownModule():
        self.assertFalse(task.cancelled())
        self.assertIs(task.exception(), base_exc)

    @ignore_warnings(category=DeprecationWarning)
    def test_iscoroutinefunction(self):
        def fn():
            pass
        self.assertFalse(asyncio.iscoroutinefunction(mock.Mock()))
        self.assertTrue(asyncio.iscoroutinefunction(mock.AsyncMock()))

    @ignore_warnings(category=DeprecationWarning)
    def test_coroutine_non_gen_function(self):
        async def func():
            return 'test'
diff --git a/Lib/test/test_unittest/testmock/testmagicmethods.py b/Lib/test/test_unittest/testmock/testmagicmethods.py
 import math
 import unittest
 import os
 fromasyncio import iscoroutinefunction
 frominspect import iscoroutinefunction
 from unittest.mock import AsyncMock, Mock, MagicMock, _magics


diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
 import sys
 import builtins
 import pkgutil
 fromasyncio import iscoroutinefunction
 frominspect import iscoroutinefunction
 import threading
 from types import CodeType, ModuleType, MethodType
 from unittest.util import safe_repr
    recognized as an async function, and the result of a call is an awaitable:

    >>> mock = AsyncMock()
    >>> iscoroutinefunction(mock)
    >>>inspect.iscoroutinefunction(mock)
    True
    >>> inspect.isawaitable(mock())
    True
diff --git a/Misc/NEWS.d/next/Library/2024-08-10-10-21-44.gh-issue-122858.ZC1rJD.rst b/Misc/NEWS.d/next/Library/2024-08-10-10-21-44.gh-issue-122858.ZC1rJD.rst
 Deprecate :func:`!asyncio.iscoroutinefunction` in favor of
 :func:`inspect.iscoroutinefunction`.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -882,7 +882,7 @@ object::
		call is an awaitable.

		>>> mock = AsyncMock()
		>>>asyncio.iscoroutinefunction(mock)
		>>>inspect.iscoroutinefunction(mock)
		True
		>>> inspect.isawaitable(mock()) # doctest: +SKIP
		True
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -425,6 +425,11 @@ Deprecated
		:c:macro:`!isfinite` available from :file:`math.h`
		since C99. (Contributed by Sergey B Kirpichev in :gh:`119613`.)

		* :func:`!asyncio.iscoroutinefunction` is deprecated
		and will be removed in Python 3.16,
		use :func:`inspect.iscoroutinefunction` instead.
		(Contributed by Jiahao Li and Kumar Aditya in :gh:`122875`.)

		.. Add deprecations above alphabetically, not here at the end.

		.. include:: ../deprecations/c-api-pending-removal-in-3.15.rst
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -837,7 +837,7 @@ def call_soon(self, callback, *args, context=None):

		def _check_callback(self, callback, method):
		if (coroutines.iscoroutine(callback) or
		coroutines.iscoroutinefunction(callback)):
		coroutines._iscoroutinefunction(callback)):
		raise TypeError(
		f"coroutines cannot be used with {method}()")
		if not callable(callback):
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,7 +18,16 @@ def _is_debug_mode():


		defiscoroutinefunction(func):
		importwarnings
		"""Return True if func is a decorated coroutine function."""
		warnings._deprecated("asyncio.iscoroutinefunction",
		f"{warnings._DEPRECATED_MSG}; "
		"use inspect.iscoroutinefunction() instead",
		remove=(3,16))
		return_iscoroutinefunction(func)


		def_iscoroutinefunction(func):
		return (inspect.iscoroutinefunction(func)or
		getattr(func,'_is_coroutine',None)is_is_coroutine)

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -95,7 +95,7 @@ def add_signal_handler(self, sig, callback, *args):
		Raise RuntimeError if there is a problem setting up the handler.
		"""
		if (coroutines.iscoroutine(callback) or
		coroutines.iscoroutinefunction(callback)):
		coroutines._iscoroutinefunction(callback)):
		raise TypeError("coroutines cannot be used "
		"with add_signal_handler()")
		self._check_signal(sig)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -124,10 +124,10 @@ def foo(): yield

		self.assertFalse(asyncio.iscoroutine(foo()))


		def test_iscoroutinefunction(self):
		async def foo(): pass
		self.assertTrue(asyncio.iscoroutinefunction(foo))
		with self.assertWarns(DeprecationWarning):
		self.assertTrue(asyncio.iscoroutinefunction(foo))

		def test_async_def_coroutines(self):
		async def bar():
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,6 +20,7 @@
		from test.test_asyncio import utils as test_utils
		from test import support
		from test.support.script_helper import assert_python_ok
		from test.support.warnings_helper import ignore_warnings


		def tearDownModule():
Expand DownExpand Up		@@ -1939,6 +1940,7 @@ async def notmutch():
		self.assertFalse(task.cancelled())
		self.assertIs(task.exception(), base_exc)

		@ignore_warnings(category=DeprecationWarning)
		def test_iscoroutinefunction(self):
		def fn():
		pass
Expand All		@@ -1956,6 +1958,7 @@ async def fn2():
		self.assertFalse(asyncio.iscoroutinefunction(mock.Mock()))
		self.assertTrue(asyncio.iscoroutinefunction(mock.AsyncMock()))

		@ignore_warnings(category=DeprecationWarning)
		def test_coroutine_non_gen_function(self):
		async def func():
		return 'test'
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,7 +1,7 @@
		import math
		import unittest
		import os
		fromasyncio import iscoroutinefunction
		frominspect import iscoroutinefunction
		from unittest.mock import AsyncMock, Mock, MagicMock, _magics


Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -32,7 +32,7 @@
		import sys
		import builtins
		import pkgutil
		fromasyncio import iscoroutinefunction
		frominspect import iscoroutinefunction
		import threading
		from types import CodeType, ModuleType, MethodType
		from unittest.util import safe_repr
Expand DownExpand Up		@@ -2456,7 +2456,7 @@ class AsyncMock(AsyncMockMixin, AsyncMagicMixin, Mock):
		recognized as an async function, and the result of a call is an awaitable:

		>>> mock = AsyncMock()
		>>> iscoroutinefunction(mock)
		>>>inspect.iscoroutinefunction(mock)
		True
		>>> inspect.isawaitable(mock())
		True
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Deprecate :func:`!asyncio.iscoroutinefunction` in favor of
		:func:`inspect.iscoroutinefunction`.