Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-122744: test_venv: ignore pip's complaint about missing ssl#122776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 1 commit intopython:mainfromencukou:whats-this-truststore-thing
Aug 8, 2024

Conversation

@encukou
Copy link
Member

@encukouencukou commentedAug 7, 2024•
edited by bedevere-appbot
Loading

@encukouencukou requested a review fromvsajip as acode ownerAugust 7, 2024 12:39
@bedevere-appbedevere-appbot added the testsTests in the Lib/test dir labelAug 7, 2024
@sethmlarson
Copy link
Contributor

I can't speak for pip maintainers, but I do wonder if the phrasing of "truststore" is a hold-over from when it was an optional feature enabled by flag (ie--use-feature=truststore) instead of the actual feature name? Maybe the skipped warning can look forssl support is missing instead of the full sentence?

encukou reacted with thumbs up emoji

@encukou
Copy link
MemberAuthor

Well, we can easily adjust wheneverpip is updated again -- it'll be in a new CPython PR, anyway.
I'll merge now to unblock the buildbots, useing the full message to avoid guessing about the future.

pradyunsg reacted with thumbs up emoji

@encukouencukou merged commit0d9c123 intopython:mainAug 8, 2024
@encukouencukou deleted the whats-this-truststore-thing branchAugust 8, 2024 09:21
@encukouencukou added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsAug 8, 2024
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 8, 2024
…ythonGH-122776)(cherry picked from commit0d9c123)Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 8, 2024
…ythonGH-122776)(cherry picked from commit0d9c123)Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

GH-122822 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelAug 8, 2024
@bedevere-app
Copy link

GH-122823 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelAug 8, 2024
encukou added a commit that referenced this pull requestAug 9, 2024
…GH-122776) (GH-122823)(cherry picked from commit0d9c123)Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull requestAug 9, 2024
…GH-122776) (GH-122822)(cherry picked from commit0d9c123)Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vsajipvsajipvsajip approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@sethmlarson@vsajip
[8]ページ先頭
©2009-2025 Movatter.jp