Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON#122764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for this fix@mhsmith, much appreciated.
I did do a quick check - this rename is complete, no `MODULE_LDFLAGS left except for the news snippet added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this!
@erlend-aasland: Thanks; are you able to merge this? There will also be a 3.13 backport. |
2f5c3b0 intopython:mainUh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
…ON (pythonGH-122764)(LIBPYTHON was renamed MODULE_LDFLAGS in commit7f5e3f0.)(cherry picked from commit2f5c3b0)Co-authored-by: Malcolm Smith <smith@chaquo.com>
GH-122842 is a backport of this pull request to the3.13 branch. |
…ON (python#122764)(LIBPYTHON was renamed MODULE_LDFLAGS in commit7f5e3f0.)
Uh oh!
There was an error while loading.Please reload this page.
This variable was renamed to MODULE_LDFLAGS in#115780, but as discussed at#115780 (comment), Meson depends on the old name LIBPYTHON. Some other package build scripts probably have the same issue.