Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-123572: Fix key codes in VK_MAP in windows_console.py#122692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 2 commits intopython:mainfromdevdanzin:fix_vk_map
Sep 3, 2024

Conversation

@devdanzin
Copy link
Member

@devdanzindevdanzin commentedAug 5, 2024•
edited by bedevere-appbot
Loading

This trivial PR corrects a couple Virtual-Key Codes found inVK_MAP in windows_console.py. It should have no impact on real use of the new REPL, as AFAIK those VKs are unused.

cc@DinoV

@picnixzpicnixz changed the title_pyrepl typo: Fix key codes in VK_MAP in windows_console.pygh-123572: Fix key codes in VK_MAP in windows_console.pySep 2, 2024
@picnixz
Copy link
Member

Can you please add a NEWS entry? you can use the formulation of#123573 if you want.

@pablogsalpablogsal added the needs backport to 3.13bugs and security fixes labelSep 3, 2024
@pablogsal
Copy link
Member

@devdanzin I have pushed a news entry for you. Next time you can do as@picnixz indicates or using theblu tool.

Copy link
Member

@pablogsalpablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Thanks for the PR@devdanzin and@picnixz for the review!

@picnixz
Copy link
Member

(I haven't done much :') but thanks for the thanks)

@pablogsalpablogsal merged commit782217f intopython:mainSep 3, 2024
@miss-islington-app
Copy link

Thanks@devdanzin for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 3, 2024
…nGH-122692)(cherry picked from commit782217f)Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
@bedevere-app
Copy link

GH-123632 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 3, 2024
pablogsal pushed a commit that referenced this pull requestSep 3, 2024
…22692) (#123632)gh-123572: Fix key codes in VK_MAP in windows_console.py (GH-122692)(cherry picked from commit782217f)Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devdanzin@picnixz@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp