Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-122559: Synchronize C and Python implementation of the io module about pickling#122628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-122559: Synchronize C and Python implementation of the io module about pickling#122628
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…dule about picklingIn the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are there checks for theTypeError
when it's not subclassed?
Misc/NEWS.d/next/Library/2024-08-02-20-01-36.gh-issue-122559.2JlJr3.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…JlJr3.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
The current behavior is inconsistent, so I have not add tests for it. |
e9253eb
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry,@serhiy-storchaka, I could not cleanly backport this to
|
Sorry,@serhiy-storchaka, I could not cleanly backport this to
|
…e io module about pickling (pythonGH-122628)In the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.(cherry picked from commite9253eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-133381 is a backport of this pull request to the3.13 branch. |
…odule about pickling (GH-122628) (GH-133381)In the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.(cherry picked from commite9253eb)
bedevere-bot commentedMay 4, 2025
|
* origin/main: (111 commits)pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)pythongh-131178: Add tests for `ast` command-line interface (python#133329) Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)pythongh-132457: make staticmethod and classmethod generic (python#132460)pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358) bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284) ...
Uh oh!
There was an error while loading.Please reload this page.
In the C implementation, remove
__reduce__
and__reduce_ex__
methods that always raise TypeError and restore__getstate__
methods that always raise TypeErrori.This restores fine details of the pre-3.12 behavior and unifies both implementations.