Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-122559: Synchronize C and Python implementation of the io module about pickling#122628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedAug 2, 2024
edited
Loading

In the C implementation, remove__reduce__ and__reduce_ex__ methods that always raise TypeError and restore__getstate__ methods that always raise TypeErrori.

This restores fine details of the pre-3.12 behavior and unifies both implementations.

…dule about picklingIn the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are there checks for theTypeError when it's not subclassed?

…JlJr3.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@serhiy-storchaka
Copy link
MemberAuthor

Are there checks for theTypeError when it's not subclassed?

The current behavior is inconsistent, so I have not add tests for it.

picnixz reacted with thumbs up emoji

@serhiy-storchakaserhiy-storchaka added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsSep 9, 2024
@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)May 4, 2025 13:43
@serhiy-storchakaserhiy-storchaka merged commite9253eb intopython:mainMay 4, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker e9253ebf74433de5ae6d7f1bce693a3a1173b3b1 3.13

@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker e9253ebf74433de5ae6d7f1bce693a3a1173b3b1 3.12

@serhiy-storchakaserhiy-storchaka removed the needs backport to 3.12only security fixes labelMay 4, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestMay 4, 2025
…e io module about pickling (pythonGH-122628)In the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.(cherry picked from commite9253eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-133381 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 4, 2025
serhiy-storchaka added a commit that referenced this pull requestMay 4, 2025
…odule about pickling (GH-122628) (GH-133381)In the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.(cherry picked from commite9253eb)
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable Clang 3.13 (tier-2) has failed when building commit973e2d3.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1456/builds/717) and take a look at the build logs.
  4. Check if the failure is related to this commit (973e2d3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1456/builds/717

Failed tests:

  • test_interpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/threading.py", line1041, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/threading.py", line992, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/test_interpreters/test_stress.py", line47, inrun    interp= interpreters.create()  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

diegorusso added a commit to diegorusso/cpython that referenced this pull requestMay 4, 2025
* origin/main: (111 commits)pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)pythongh-131178: Add tests for `ast` command-line interface (python#133329)  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)pythongh-132457: make staticmethod and classmethod generic (python#132460)pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@serhiy-storchaka@bedevere-bot@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp