Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-122544: Change OS image in GitHub Actions to ubuntu-24.04#122566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 4 commits intopython:mainfromDamien-Chen:build-ubuntu-24.04
Nov 5, 2024

Conversation

Damien-Chen
Copy link
Contributor

@Damien-ChenDamien-Chen commentedAug 1, 2024
edited by bedevere-appbot
Loading

Change base OS image in Github Actions fromubuntu-22.04 toubuntu-24.04

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@hugovkhugovk changed the titlegh-122544: Change OS image in github workflow to ubuntu-24.04gh-122544: Change OS image in GitHub Actions to ubuntu-24.04Aug 2, 2024
@AA-Turner
Copy link
Member

Failing due toUnable to locate package libmpdec-dev, asthe libmpdec-dev package does not appear in Ubuntu 24.04 LTS. According tothis comment, the removal is intentional as it is no longer needed, seethe debian mailing list post.

@Damien-Chen are you able to test this please?

A

@Damien-Chen
Copy link
ContributorAuthor

Failing due toUnable to locate package libmpdec-dev, asthe libmpdec-dev package does not appear in Ubuntu 24.04 LTS. According tothis comment, the removal is intentional as it is no longer needed, seethe debian mailing list post.

@Damien-Chen are you able to test this please?

A

Sure!. No problem!

@AA-Turner
Copy link
Member

Theregen-all check is failing, I assume something changed between LTS versions -- can you runmake regen-all on 24.04 and push that?

A

@Damien-Chen
Copy link
ContributorAuthor

Theregen-all check is failing, I assume something changed between LTS versions -- can you runmake regen-all on 24.04 and push that?

A

Let me check if I can test it locally on my WSL2ubuntu-24.04 or use another local machine to installubuntu-24.04. Or if I can trigger all pipline on my fork repo so that I I don’t have to confirm the result every time I commit to this PR.

@Damien-Chen
Copy link
ContributorAuthor

Damien-Chen commentedAug 3, 2024
edited
Loading

Theregen-all check is failing, I assume something changed between LTS versions -- can you runmake regen-all on 24.04 and push that?

A

It means that addingmake regen-all beforegit add -u like the below image show?

  - name: Check for changes    run: |      make regen-all      git add -u      changes=$(git status --porcelain)
AA-Turner reacted with thumbs up emoji

@Damien-Chen
Copy link
ContributorAuthor

It seems same error, I run on my forked repo inthis

@AA-Turner
Copy link
Member

Sorry, I meant you need to runmake regen-all locally and commit the output of that to your branch.

@Damien-Chen
Copy link
ContributorAuthor

Sorry, I meant you need to runmake regen-all locally and commit the output of that to your branch.

It seems that the below three file cause error inubuntu-24.04
aclocal.m4,config.guess,configure.

I test it in several method. First is runmake regen-all on my localubuntun-24.04 machine, and convert the whole output into a script, and then execute it before runningCheck for changes test but it fails.
Then I copy the above three mention file generated inubuntu-24.04, and overwrite the original three file that inubuntu-22.04 and it seems pass the check.

Maybe there are some modification betweenubuntu-22.04 andubuntu-24.04 cause the above mentioned three file different ?

The whole process and result were conduct in my fork repohere

ubuntu-24.04output.txt

And the attached file is the output of runningmake regen-all inubuntu-24.04.

@Damien-Chen
Copy link
ContributorAuthor

Forubuntu-24.04, these three fileaclocal.m4,config.guess,configure are different thanubuntu-22.04. Maybe we should update these file together.

@hugovk
Copy link
Member

(Updating branch to re-trigger CLA bot, which got stuck a few days ago.)

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, CI changes look good to me. I'd like someone else (@corona10?@erlend-aasland?) to review the configure + libmpdec-dev changes.

hugovk and erlend-aasland reacted with thumbs up emoji
@hugovk
Copy link
Member

@Damien-Chen Please could you resolve the conflicts?

@erlend-aasland@corona10 Please could you check the configure + libmpdec-dev changes here?

We'll also need to upgrade doctest soon (see#125236), but that can be a separate PR.

Damien-Chen reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

I'll check it later today, when I'm back on my laptop.

hugovk reacted with thumbs up emoji

@Damien-Chen
Copy link
ContributorAuthor

Resolved conflict.

hugovk and erlend-aasland reacted with thumbs up emoji

@Damien-Chen
Copy link
ContributorAuthor

Should we merge this as early as possible?

@AA-Turner
Copy link
Member

There's no rush to merge this, it is currently blocked on review of the autoconf / configure changes. Most likely we will need to co-ordinate updating e.g. thedocker images to Ubuntu 24 too.

cc@corona10

A

corona10 and Damien-Chen reacted with thumbs up emoji

ambv added a commit that referenced this pull requestNov 22, 2024
@Damien-ChenDamien-Chen deleted the build-ubuntu-24.04 branchNovember 24, 2024 03:36
hugovk added a commit that referenced this pull requestJan 11, 2025
…122566) (#126621)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

Let's backport this to 3.9-3.11, they're still using someubuntu-20.04 which is deprecated and will be fully unsupported by 2025-04-01, with brownouts in March:

actions/runner-images#11101

@miss-islington-app
Copy link

Thanks@Damien-Chen for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@Damien-Chen for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@Damien-Chen for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@Damien-Chen and@erlend-aasland, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker fc233f46d3761b4e808be2c44fda0b843179004e 3.9

@miss-islington-app
Copy link

Sorry,@Damien-Chen and@erlend-aasland, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker fc233f46d3761b4e808be2c44fda0b843179004e 3.10

@miss-islington-app
Copy link

Sorry,@Damien-Chen and@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker fc233f46d3761b4e808be2c44fda0b843179004e 3.11

hugovk pushed a commit to hugovk/cpython that referenced this pull requestFeb 18, 2025
@bedevere-app
Copy link

GH-130260 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 18, 2025
@bedevere-app
Copy link

GH-130268 is a backport of this pull request to the3.10 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelFeb 18, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull requestFeb 19, 2025
@bedevere-app
Copy link

GH-130295 is a backport of this pull request to the3.9 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.9only security fixes labelFeb 19, 2025
@bedevere-app
Copy link

GH-130260 is a backport of this pull request to the3.11 branch.

@bedevere-app
Copy link

GH-130268 is a backport of this pull request to the3.10 branch.

@bedevere-app
Copy link

GH-130295 is a backport of this pull request to the3.9 branch.

ambv pushed a commit that referenced this pull requestFeb 19, 2025
…H-122566) (#130268)Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>
ambv pushed a commit that referenced this pull requestFeb 19, 2025
…122566) (#130295)Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@corona10corona10corona10 approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@erlend-aaslanderlend-aasland

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change base OS image to Ubuntu-24.04 in CI testing
5 participants
@Damien-Chen@AA-Turner@hugovk@erlend-aasland@corona10

[8]ページ先頭

©2009-2025 Movatter.jp