Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-94512: Fix forced arg format in AC-processedposixmodule.c#122516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedJul 31, 2024
edited
Loading

@picnixzpicnixz changed the titlesimplify conversionsgh-94512: Fix forced arg format in AC-processedposixmodule.cJul 31, 2024
ival=PyLong_AsSsize_t(iobj);
Py_DECREF(iobj);
}
if (ival==-1&&PyErr_Occurred()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should teach Argument Clinic to generate this as:

if (ival== (Py_ssize_t)-1&&PyErr_Occurred()) {

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can work on a fix tomorrow if you want?

erlend-aasland reacted with thumbs up emoji
@erlend-aasland
Copy link
Contributor

Thanks, Bénédikt!

picnixz reacted with heart emoji

@erlend-aaslanderlend-aasland merged commitf6cc7c8 intopython:mainOct 26, 2024
@picnixzpicnixz deleted the forced-arg-in-AC-posixmodule branchOctober 26, 2024 22:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@erlend-aasland

[8]ページ先頭

©2009-2025 Movatter.jp