Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-122420: Fix accounting for immortal interned strings in refleak.py#122421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@colesbury
Copy link
Contributor

@colesburycolesbury commentedJul 29, 2024•
edited by bedevere-appbot
Loading

The_PyUnicode_Intern* functions already adjust the total refcount, so we don't want to readjust it in refleak.py.

…leak.pyThe `_PyUnicode_Intern*` functions already adjust the total refcount, sowe don't want to readjust it in refleak.py.
@colesbury
Copy link
ContributorAuthor

!buildbot nogil refleak

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@colesbury for commitbbc1ddf 🤖

The command will test the builders whose names match following regular expression:nogil refleak

The builders matched are:

  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR

@colesburycolesbury changed the titlegh-122420: Fix accounting for immortal, interned strings in refleak.pygh-122420: Fix accounting for immortal interned strings in refleak.pyJul 29, 2024
@colesbury
Copy link
ContributorAuthor

!buildbot AMD64 RHEL8 Refleaks

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@colesbury for commitbbc1ddf 🤖

The command will test the builders whose names match following regular expression:AMD64 RHEL8 Refleaks

The builders matched are:

  • AMD64 RHEL8 Refleaks PR

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the catch!

@miss-islington-app
Copy link

Thanks@colesbury for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 29, 2024
…eak.py (pythonGH-122421)The `_PyUnicode_Intern*` functions already adjust the total refcount, sowe don't want to readjust it in refleak.py.(cherry picked from commitac8da34)Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

GH-122430 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 29, 2024
@colesburycolesbury deleted the gh-122420-intern-negative-refleak branchJuly 29, 2024 22:28
encukou pushed a commit that referenced this pull requestJul 30, 2024
…leak.py (GH-122421) (GH-122430)The `_PyUnicode_Intern*` functions already adjust the total refcount, sowe don't want to readjust it in refleak.py.(cherry picked from commitac8da34)Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@encukouencukouencukou approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury@bedevere-bot@encukou
[8]ページ先頭
©2009-2025 Movatter.jp