Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-84808: Handle errors returned by internal_connect()#122304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 3 commits intopython:mainfromkorli:bug84808
Sep 9, 2024

Conversation

@korli
Copy link
Contributor

@korlikorli commentedJul 26, 2024•
edited by bedevere-appbot
Loading

Python shouldn't assume that errno codes are positive.

reported and proposed by Ryan C. Gordon

@ghost
Copy link

ghost commentedJul 26, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

picnixz
picnixz previously requested changesJul 26, 2024
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@encukou
Copy link
Member

@korli: Did that help? Do you need more info?
Or would you prefer someone else to finish this PR?

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

2 similar comments
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@picnixzpicnixz dismissed theirstale reviewSeptember 6, 2024 10:04

Changes were made (just a missing NEWS entry, if needed)

internal_connect() errors when returning -1 with exception set.reported and proposed by Ryan C. Gordonerror handling scheme (raise, no raise) as suggested by encukouCo-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@korli
Copy link
ContributorAuthor

@korli: Did that help? Do you need more info? Or would you prefer someone else to finish this PR?

@encukou thanks, indeed that helps to better understand and implement the review comments. Sorry for the delay.

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

I'll touch up the NEWS entry to mention user-facing API, and merge.

In the future, please don't rebase pull requests to CPython. Rebasing throws away the previously reviewed commits, so all of the PR needs to be reviewed again.
But on small PRs like this one, it's not much of a problem :)

@encukouencukouenabled auto-merge (squash)September 9, 2024 14:39
@encukouencukou merged commit65fcaa3 intopython:mainSep 9, 2024
@korli
Copy link
ContributorAuthor

I'll touch up the NEWS entry to mention user-facing API, and merge.

Thank you!

In the future, please don't rebase pull requests to CPython. Rebasing throws away the previously reviewed commits, so all of the PR needs to be reviewed again. But on small PRs like this one, it's not much of a problem :)

Indeed, sorry I'm used to push clean commits.

encukou reacted with thumbs up emoji

@korlikorli deleted the bug84808 branchSeptember 12, 2024 05:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@encukouencukouencukou approved these changes

@picnixzpicnixzpicnixz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@korli@encukou@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp