Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
GH-120754: Add more tests around seek + readall#122103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements frompython#121593 (comment)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
hauntsaninja approved these changesJul 24, 2024
Contributor
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
Thanks@cmaloney for the PR, and@hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 24, 2024
In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements fromhttps://github.com/python/cpython/pull/121593GH-issuecomment-2222261986(cherry picked from commit9eb7341)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
GH-122215 is a backport of this pull request to the3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 24, 2024
In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements fromhttps://github.com/python/cpython/pull/121593GH-issuecomment-2222261986(cherry picked from commit9eb7341)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
GH-122216 is a backport of this pull request to the3.12 branch. |
hauntsaninja pushed a commit that referenced this pull requestJul 24, 2024
…122216)GH-120754: Add more tests around seek + readall (GH-122103)In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements fromhttps://github.com/python/cpython/pull/121593GH-issuecomment-2222261986(cherry picked from commit9eb7341)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
hauntsaninja pushed a commit that referenced this pull requestJul 24, 2024
…122215)GH-120754: Add more tests around seek + readall (GH-122103)In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements fromhttps://github.com/python/cpython/pull/121593GH-issuecomment-2222261986(cherry picked from commit9eb7341)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
nohlson pushed a commit to nohlson/cpython that referenced this pull requestJul 24, 2024
In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements frompython#121593 (comment)
nohlson pushed a commit to nohlson/cpython that referenced this pull requestJul 24, 2024
In the process of speeding up readall, A number of related tests(ex. large file tests in test_zipfile) found problems with thechange I was making. This adds I/O tests to specifically test thesecases to help ensure they don't regress and hopefully make debuggingeasier.This is part of the improvements frompython#121593 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier.
This is part of the improvements from#121593 (comment)