Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-119698: deprecatesymtable.Class.get_methods#121902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I'm not too sure about theimport warnings in the method body instead of at the module level. I'll let a core dev decide on that.
picnixz commentedJul 22, 2024
Friendly ping@JelleZijlstra in case you forgot about this one (or maybe if you were not aware of it). |
JelleZijlstra left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, hadn't seen this PR.
Uh oh!
There was an error while loading.Please reload this page.
Deprecation notice for
symtable.Class.get_methodsfor 3.14+ (to be merged after#121802 since it is included in this PR).📚 Documentation preview 📚:https://cpython-previews--121902.org.readthedocs.build/