My understanding of this stuff, particularly on the Python side, is somewhat shallow, but from a discussion with@freakboy3742 it appears we can use crash reporters with Python signal handling overrides.

📚 Documentation preview 📚:https://cpython-previews--121881.org.readthedocs.build/

Ios signal handlers

2aa4a57

michaeleisel requested a review fromfreakboy3742 as acode owner

July 16, 2024 22:40

Copy link

ghost commentedJul 16, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

bedevere-appbot added docs

Documentation in the Doc dir

skip news awaiting review labels

Jul 16, 2024

Ios signal handlers

387d424

Copy link

Author

michaeleisel commentedJul 16, 2024

Is there a better way to test the rendering of the .rst file than with rst2html.py?

freakboy3742 added needs backport to 3.13

bugs and security fixes

skip issue labels

Jul 16, 2024

Copy link

Contributor

freakboy3742 commentedJul 16, 2024

Is there a better way to test the rendering of the .rst file than with rst2html.py?

There is - when a PR includes documentation changes, the PR body is automatically updated to include a preview rendering.

Alternatively, you can render locally using Sphinx. The CPython developer guidehas a section on building the docs locally

freakboy3742 requested changes

Jul 16, 2024

View reviewed changes

Copy link

Contributor

freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This needs line breaks; documentation should be wrapped at 80 characters.

I'm also not convinced this is the best location for this comment; it breaks the bullet-point flow of "things that need to be done" (including, but not limited to the punctuation inconsistency).

I'd suggest moving this comment out of the bullet point flow, an into a paragraph following the discussion of "your apps bundle location" (i.e., a paragraph in "item 10", but not in the "things to do" bullet points.

I think the text itself also needs some modification so that it is more directly actionable.

   .. note::      Python's default signal handlers will catch the UNIX signals ``SIGPIPE``,       ``SIGXFZ``, ``SIGXFSZ``, and ``SIGINT``. These default handlers should be       able to co-exist with most third-party iOS crash reporting libraries; but       if you experience problems, you can omit the default handlers as long as       you manage these signals yourself.

bedevere-appbot removed the awaiting review label

Jul 16, 2024

Copy link

bedevere-appbot commentedJul 16, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.