Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
[3.12] CI: Fix usingcheck_source flags as bool (GH-121848)#121855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
(cherry picked from commita0b205b)Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
check_source flags as bool (GH-121848).check_source flags as bool (GH-121848)check_source flags as bool (GH-121848)check_source flags as bool (GH-121848)61d5e87 intopython:3.12 28 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, those flags would sometimes end up having empty string values, which tends to break evaluating them as JSON. This patch adds
falsefallbacks to all such outputs.This allows feeding them to
fromJSON()without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [1]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view asWaiting for pending jobsand in the${{ needs }}context, they would have aresult: failureentry [2].This should help make PRs like#121831 mergeable again.
(cherry picked from commita0b205b)