Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-120522: Revert "Add a--with-app-store-compliance configure option to patch out problematic code" (gh-120984)#121844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…e option to patch out problematic code (python#120984)"This reverts commit48cd104 priorto the release of 3.13.0b4 to allow for additional review time.
freakboy3742 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One note about a part of the patch that probably shouldn't be reverted (but is easy to fix again later), but otherwise LGTM.
| The module has been designed to match the internet RFC on Relative Uniform | ||
| Resource Locators. It supports the following URL schemes: ``file``, ``ftp``, | ||
| ``gopher``, ``hdl``, ``http``, ``https``, ``imap``, ``itms-services``, ``mailto``, ``mms``, | ||
| ``gopher``, ``hdl``, ``http``, ``https``, ``imap``, ``mailto``, ``mms``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's worth noting that while this is what would be a strict reverse of the original PR, this change was actually correct - the list didn't previously listitms-services at all, despite being supported.
Thanks@ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…e option to patch out problematic code" (pythongh-120984) (pythonGH-121844)This reverts commit48cd104 priorto the release of 3.13.0b4 to allow for additional review time.(cherry picked from commitf27593a)Co-authored-by: Ned Deily <nad@python.org>
GH-121845 is a backport of this pull request to the3.13 branch. |
…e option to patch out problematic code" (pythongh-120984) (python#121844)This reverts commit48cd104 priorto the release of 3.13.0b4 to allow for additional review time.
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit48cd104 prior to the release of 3.13.0b4 to allow for additional review time.
📚 Documentation preview 📚:https://cpython-previews--121844.org.readthedocs.build/